You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Azrael Park <az...@nexr.com> on 2014/08/19 09:02:20 UTC

Review Request 24837: OOZIE-1779 Add parent-id as a filter option

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24837/
-----------------------------------------------------------

Review request for oozie.


Bugs: OOZIE-1779
    https://issues.apache.org/jira/browse/OOZIE-1779


Repository: oozie-git


Description
-------

* Add parentid to filter option.
* Reuse StoreStatusFilter.filter() method to generate queryString for getting all job info(WF, COORD, BUNDLE) so that the duplicated/obsolete code removed. (OOZIE-1927)


Diffs
-----

  client/src/main/java/org/apache/oozie/client/OozieClient.java b468186 
  core/src/main/java/org/apache/oozie/BundleEngine.java 67f4aba 
  core/src/main/java/org/apache/oozie/CoordinatorEngine.java dd5c703 
  core/src/main/java/org/apache/oozie/DagEngine.java f6e5b4f 
  core/src/main/java/org/apache/oozie/executor/jpa/BundleJobInfoGetJPAExecutor.java c663e07 
  core/src/main/java/org/apache/oozie/executor/jpa/CoordJobInfoGetJPAExecutor.java 8008737 
  core/src/main/java/org/apache/oozie/executor/jpa/WorkflowsJobGetJPAExecutor.java 6750501 
  core/src/main/java/org/apache/oozie/store/CoordinatorStore.java 9021778 
  core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java 8025b75 
  core/src/main/java/org/apache/oozie/store/WorkflowStore.java fe43130 
  core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java e3db675 
  core/src/test/java/org/apache/oozie/TestDagEngine.java 33dc97f 
  core/src/test/java/org/apache/oozie/store/TestDBWorkflowStore.java ff87c10 
  core/src/test/java/org/apache/oozie/store/TestStoreStatusFilter.java PRE-CREATION 

Diff: https://reviews.apache.org/r/24837/diff/


Testing
-------

Unit test done.
Manaul test done.


Thanks,

Azrael Park


Re: Review Request 24837: OOZIE-1779 Add parent-id as a filter option

Posted by Azrael Park <az...@nexr.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24837/
-----------------------------------------------------------

(Updated Aug. 20, 2014, 5:32 a.m.)


Review request for oozie.


Changes
-------

* Fix test failure
* Make filter name rule for WF, COORD, BUNDLE to be consistent : throw exception if upper case


Bugs: OOZIE-1779
    https://issues.apache.org/jira/browse/OOZIE-1779


Repository: oozie-git


Description
-------

* Add parentid to filter option.
* Reuse StoreStatusFilter.filter() method to generate queryString for getting all job info(WF, COORD, BUNDLE) so that the duplicated/obsolete code removed. (OOZIE-1927)


Diffs (updated)
-----

  client/src/main/java/org/apache/oozie/client/OozieClient.java b468186 
  core/src/main/java/org/apache/oozie/BundleEngine.java 67f4aba 
  core/src/main/java/org/apache/oozie/CoordinatorEngine.java dd5c703 
  core/src/main/java/org/apache/oozie/DagEngine.java f6e5b4f 
  core/src/main/java/org/apache/oozie/executor/jpa/BundleJobInfoGetJPAExecutor.java c663e07 
  core/src/main/java/org/apache/oozie/executor/jpa/CoordJobInfoGetJPAExecutor.java 8008737 
  core/src/main/java/org/apache/oozie/executor/jpa/WorkflowsJobGetJPAExecutor.java 6750501 
  core/src/main/java/org/apache/oozie/store/CoordinatorStore.java 9021778 
  core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java 8025b75 
  core/src/main/java/org/apache/oozie/store/WorkflowStore.java fe43130 
  core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java 1904519 
  core/src/test/java/org/apache/oozie/TestDagEngine.java 33dc97f 
  core/src/test/java/org/apache/oozie/store/TestDBWorkflowStore.java ff87c10 
  core/src/test/java/org/apache/oozie/store/TestStoreStatusFilter.java PRE-CREATION 

Diff: https://reviews.apache.org/r/24837/diff/


Testing
-------

Unit test done.
Manaul test done.


Thanks,

Azrael Park