You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "mhoffrog (via GitHub)" <gi...@apache.org> on 2025/05/20 15:47:56 UTC
[PR] [fix] service.bat JvmOptions9 - FollowUp on Improve CVE-2024-56337 protection [tomcat]
mhoffrog opened a new pull request, #858:
URL: https://github.com/apache/tomcat/pull/858
**Reference:** Commit 0c75cd1e3ac85944fb8ecbcf88cc38e9fa1fe4d5 by @markt-asf
**Issue:** The commit referred did miss to keep `service.bat` JvmOptions9 in line with the change of catalina.bat made by that commit.
**Changes:**
- service.bat:
- fix JvmOptions9 to followup according changes in catalina.bat
- improve legibility of JvmOptions9 parameter line by introducing intermediate set variable JVM9_OPTIONS
- add comment to JVM9_OPTIONS settings with hint to keep in line with catalina.bat
- catalina.bat:
- add comment to JDK_JAVA_OPTIONS --add-opens settings with hint to keep in line with service.bat
**Test result:**

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] [fix] service.bat JvmOptions9 - FollowUp on Improve CVE-2024-56337 protection [tomcat]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #858:
URL: https://github.com/apache/tomcat/pull/858#discussion_r2099737527
##########
bin/catalina.bat:
##########
@@ -243,7 +243,7 @@ if not "%LOGGING_MANAGER%" == "" goto noJuliManager
set LOGGING_MANAGER=-Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager
:noJuliManager
-rem Configure JAVA 9 specific start-up parameters
+rem Configure JAVA 9 specific start-up parameters - KEEP in line with service.bat
Review Comment:
Proposal is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] [fix] service.bat JvmOptions9 - FollowUp on Improve CVE-2024-56337 protection [tomcat]
Posted by "rainerjung (via GitHub)" <gi...@apache.org>.
rainerjung commented on PR #858:
URL: https://github.com/apache/tomcat/pull/858#issuecomment-2895052975
Docs for Commons Daemon Procrun mention, that JvmOptions9 can use the same two separators, that JvmOptions can use. Namely ";" and "#". Currently we use ";" for JvmOptions and "#" for JvmOptions9. It might make sense to use ";" for both for compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] [fix] service.bat JvmOptions9 - FollowUp on Improve CVE-2024-56337 protection [tomcat]
Posted by "mhoffrog (via GitHub)" <gi...@apache.org>.
mhoffrog commented on code in PR #858:
URL: https://github.com/apache/tomcat/pull/858#discussion_r2099778013
##########
bin/catalina.bat:
##########
@@ -243,7 +243,7 @@ if not "%LOGGING_MANAGER%" == "" goto noJuliManager
set LOGGING_MANAGER=-Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager
:noJuliManager
-rem Configure JAVA 9 specific start-up parameters
+rem Configure JAVA 9 specific start-up parameters - KEEP in line with service.bat
Review Comment:
> Proposal is fine.
You mean I should change it as I did propose or is it fine as it is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] [fix] service.bat JvmOptions9 - FollowUp on Improve CVE-2024-56337 protection [tomcat]
Posted by "mhoffrog (via GitHub)" <gi...@apache.org>.
mhoffrog commented on PR #858:
URL: https://github.com/apache/tomcat/pull/858#issuecomment-2895493402
> Docs for Commons Daemon Procrun mention, that JvmOptions9 can use the same two separators, that JvmOptions can use. Namely ";" and "#". Currently we use ";" for JvmOptions and "#" for JvmOptions9. It might make sense to use ";" for both for consistency.
@rainerjung Thanks for this hint - Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] [fix] service.bat JvmOptions9 - FollowUp on Improve CVE-2024-56337 protection [tomcat]
Posted by "mhoffrog (via GitHub)" <gi...@apache.org>.
mhoffrog commented on code in PR #858:
URL: https://github.com/apache/tomcat/pull/858#discussion_r2099932516
##########
bin/catalina.bat:
##########
@@ -243,7 +243,7 @@ if not "%LOGGING_MANAGER%" == "" goto noJuliManager
set LOGGING_MANAGER=-Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager
:noJuliManager
-rem Configure JAVA 9 specific start-up parameters
+rem Configure JAVA 9 specific start-up parameters - KEEP in line with service.bat
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] [fix] service.bat JvmOptions9 - FollowUp on Improve CVE-2024-56337 protection [tomcat]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #858:
URL: https://github.com/apache/tomcat/pull/858#discussion_r2099821491
##########
bin/catalina.bat:
##########
@@ -243,7 +243,7 @@ if not "%LOGGING_MANAGER%" == "" goto noJuliManager
set LOGGING_MANAGER=-Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager
:noJuliManager
-rem Configure JAVA 9 specific start-up parameters
+rem Configure JAVA 9 specific start-up parameters - KEEP in line with service.bat
Review Comment:
Change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] [fix] service.bat JvmOptions9 - FollowUp on Improve CVE-2024-56337 protection [tomcat]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #858:
URL: https://github.com/apache/tomcat/pull/858#discussion_r2099371131
##########
bin/catalina.bat:
##########
@@ -243,7 +243,7 @@ if not "%LOGGING_MANAGER%" == "" goto noJuliManager
set LOGGING_MANAGER=-Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager
:noJuliManager
-rem Configure JAVA 9 specific start-up parameters
+rem Configure JAVA 9 specific start-up parameters - KEEP in line with service.bat
Review Comment:
What is this acronym "KEEP"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] [fix] service.bat JvmOptions9 - FollowUp on Improve CVE-2024-56337 protection [tomcat]
Posted by "mhoffrog (via GitHub)" <gi...@apache.org>.
mhoffrog commented on code in PR #858:
URL: https://github.com/apache/tomcat/pull/858#discussion_r2099684597
##########
bin/catalina.bat:
##########
@@ -243,7 +243,7 @@ if not "%LOGGING_MANAGER%" == "" goto noJuliManager
set LOGGING_MANAGER=-Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager
:noJuliManager
-rem Configure JAVA 9 specific start-up parameters
+rem Configure JAVA 9 specific start-up parameters - KEEP in line with service.bat
Review Comment:
@michael-o It is intended as verb to "keep" those settings maintained in line with the settings in service.bat. I made it upper case to catch eyes. If it raises irritating by associating with an unknown acronym I could change it e.g. to
`Configure JAVA 9 specific start-up parameters - ensure to keep it in line with service.bat` or any other proposal from your end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] [fix] service.bat JvmOptions9 - FollowUp on Improve CVE-2024-56337 protection [tomcat]
Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf merged PR #858:
URL: https://github.com/apache/tomcat/pull/858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org