You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Xianqing He (Code Review)" <ge...@cloudera.org> on 2022/09/09 10:22:12 UTC

[Impala-ASF-CR] IMPALA-11557:Fix memory leak in BlockingRowBatchQueue

Xianqing He has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18960


Change subject: IMPALA-11557:Fix memory leak in BlockingRowBatchQueue
......................................................................

IMPALA-11557:Fix memory leak in BlockingRowBatchQueue

'batch_queue_' is a pointer to store the RowBatches. It's
initialized in the constructor but not deleted in the destructor.

The way to fix in the patch is to use std::unique_ptr.

Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56
---
M be/src/runtime/blocking-row-batch-queue.h
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/18960/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56
Gerrit-Change-Number: 18960
Gerrit-PatchSet: 1
Gerrit-Owner: Xianqing He <he...@126.com>

[Impala-ASF-CR] IMPALA-11557: Fix memory leak in BlockingRowBatchQueue

Posted by "Xianqing He (Code Review)" <ge...@cloudera.org>.
Xianqing He has posted comments on this change. ( http://gerrit.cloudera.org:8080/18960 )

Change subject: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18960/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18960/1//COMMIT_MSG@7
PS1, Line 7: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue
> nit: add space
Done


http://gerrit.cloudera.org:8080/#/c/18960/1/be/src/runtime/blocking-row-batch-queue.h
File be/src/runtime/blocking-row-batch-queue.h:

http://gerrit.cloudera.org:8080/#/c/18960/1/be/src/runtime/blocking-row-batch-queue.h@112
PS1, Line 112: std::unique_ptr
> optional: Can't we use BlockingQueue directly as member without ptr/unique_
Yes, I think we can. But that requires more changes, we should change '->' to '.'



-- 
To view, visit http://gerrit.cloudera.org:8080/18960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56
Gerrit-Change-Number: 18960
Gerrit-PatchSet: 2
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Xianqing He <he...@126.com>
Gerrit-Comment-Date: Tue, 13 Sep 2022 03:35:02 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11557: Fix memory leak in BlockingRowBatchQueue

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18960 )

Change subject: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue
......................................................................


Patch Set 3:

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8570/


-- 
To view, visit http://gerrit.cloudera.org:8080/18960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56
Gerrit-Change-Number: 18960
Gerrit-PatchSet: 3
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Xianqing He <he...@126.com>
Gerrit-Comment-Date: Wed, 14 Sep 2022 12:51:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11557: Fix memory leak in BlockingRowBatchQueue

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18960 )

Change subject: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11340/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56
Gerrit-Change-Number: 18960
Gerrit-PatchSet: 2
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Sep 2022 03:28:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11557:Fix memory leak in BlockingRowBatchQueue

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18960 )

Change subject: IMPALA-11557:Fix memory leak in BlockingRowBatchQueue
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11326/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56
Gerrit-Change-Number: 18960
Gerrit-PatchSet: 1
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Sep 2022 10:43:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11557: Fix memory leak in BlockingRowBatchQueue

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has removed a vote on this change.

Change subject: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue
......................................................................


Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
-- 
To view, visit http://gerrit.cloudera.org:8080/18960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56
Gerrit-Change-Number: 18960
Gerrit-PatchSet: 3
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Xianqing He <he...@126.com>

[Impala-ASF-CR] IMPALA-11557: Fix memory leak in BlockingRowBatchQueue

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18960 )

Change subject: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue
......................................................................

IMPALA-11557: Fix memory leak in BlockingRowBatchQueue

'batch_queue_' is a pointer to store the RowBatches. It's
initialized in the constructor but not deleted in the destructor.

The way to fix in the patch is to use std::unique_ptr.

Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56
Reviewed-on: http://gerrit.cloudera.org:8080/18960
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Quanlong Huang <hu...@gmail.com>
---
M be/src/runtime/blocking-row-batch-queue.h
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved
  Quanlong Huang: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56
Gerrit-Change-Number: 18960
Gerrit-PatchSet: 4
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Xianqing He <he...@126.com>

[Impala-ASF-CR] IMPALA-11557: Fix memory leak in BlockingRowBatchQueue

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18960 )

Change subject: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56
Gerrit-Change-Number: 18960
Gerrit-PatchSet: 2
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Xianqing He <he...@126.com>
Gerrit-Comment-Date: Tue, 13 Sep 2022 12:29:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11557: Fix memory leak in BlockingRowBatchQueue

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18960 )

Change subject: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8570/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56
Gerrit-Change-Number: 18960
Gerrit-PatchSet: 3
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Xianqing He <he...@126.com>
Gerrit-Comment-Date: Wed, 14 Sep 2022 07:33:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11557: Fix memory leak in BlockingRowBatchQueue

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18960 )

Change subject: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8568/


-- 
To view, visit http://gerrit.cloudera.org:8080/18960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56
Gerrit-Change-Number: 18960
Gerrit-PatchSet: 3
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Xianqing He <he...@126.com>
Gerrit-Comment-Date: Wed, 14 Sep 2022 07:11:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11557: Fix memory leak in BlockingRowBatchQueue

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18960 )

Change subject: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8568/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56
Gerrit-Change-Number: 18960
Gerrit-PatchSet: 3
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Xianqing He <he...@126.com>
Gerrit-Comment-Date: Wed, 14 Sep 2022 02:05:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11557:Fix memory leak in BlockingRowBatchQueue

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18960 )

Change subject: IMPALA-11557:Fix memory leak in BlockingRowBatchQueue
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18960/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18960/1//COMMIT_MSG@7
PS1, Line 7: IMPALA-11557:Fix memory leak in BlockingRowBatchQueue
nit: add space


http://gerrit.cloudera.org:8080/#/c/18960/1/be/src/runtime/blocking-row-batch-queue.h
File be/src/runtime/blocking-row-batch-queue.h:

http://gerrit.cloudera.org:8080/#/c/18960/1/be/src/runtime/blocking-row-batch-queue.h@112
PS1, Line 112: std::unique_ptr
optional: Can't we use BlockingQueue directly as member without ptr/unique_ptr?



-- 
To view, visit http://gerrit.cloudera.org:8080/18960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56
Gerrit-Change-Number: 18960
Gerrit-PatchSet: 1
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Sep 2022 13:45:39 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11557: Fix memory leak in BlockingRowBatchQueue

Posted by "Xianqing He (Code Review)" <ge...@cloudera.org>.
Xianqing He has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18960 )

Change subject: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue
......................................................................

IMPALA-11557: Fix memory leak in BlockingRowBatchQueue

'batch_queue_' is a pointer to store the RowBatches. It's
initialized in the constructor but not deleted in the destructor.

The way to fix in the patch is to use std::unique_ptr.

Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56
---
M be/src/runtime/blocking-row-batch-queue.h
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/18960/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56
Gerrit-Change-Number: 18960
Gerrit-PatchSet: 2
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>

[Impala-ASF-CR] IMPALA-11557: Fix memory leak in BlockingRowBatchQueue

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18960 )

Change subject: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue
......................................................................


Patch Set 2: Code-Review+2

Carry Csaba's +1. Thanks for fixing this, Xianqing!


-- 
To view, visit http://gerrit.cloudera.org:8080/18960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56
Gerrit-Change-Number: 18960
Gerrit-PatchSet: 2
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Xianqing He <he...@126.com>
Gerrit-Comment-Date: Wed, 14 Sep 2022 02:04:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11557: Fix memory leak in BlockingRowBatchQueue

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18960 )

Change subject: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56
Gerrit-Change-Number: 18960
Gerrit-PatchSet: 3
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Xianqing He <he...@126.com>
Gerrit-Comment-Date: Wed, 14 Sep 2022 02:05:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11557: Fix memory leak in BlockingRowBatchQueue

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18960 )

Change subject: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue
......................................................................


Patch Set 3:

> Patch Set 3: Verified-1
> 
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8568/

The failure is a flaky test tracked in IMPALA-11508
https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/6311


-- 
To view, visit http://gerrit.cloudera.org:8080/18960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56
Gerrit-Change-Number: 18960
Gerrit-PatchSet: 3
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Xianqing He <he...@126.com>
Gerrit-Comment-Date: Wed, 14 Sep 2022 07:33:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11557: Fix memory leak in BlockingRowBatchQueue

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18960 )

Change subject: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue
......................................................................


Patch Set 3: Verified+1

> Patch Set 3:
> 
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8570/

Hit another two flaky tests:
https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/6313/ (IMPALA-11160)
https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/17556/ (IMPALA-11572)

Merging this.


-- 
To view, visit http://gerrit.cloudera.org:8080/18960
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56
Gerrit-Change-Number: 18960
Gerrit-PatchSet: 3
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Xianqing He <he...@126.com>
Gerrit-Comment-Date: Thu, 15 Sep 2022 00:10:09 +0000
Gerrit-HasComments: No