You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ross Allen <ro...@mesosphe.re> on 2013/07/10 03:56:16 UTC
Review Request 12391: Format dates as ISO instead of American
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12391/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Log dates are printed as ISO, not the American format. This makes copying/pasting more straightforward.
Diffs
-----
src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
Diff: https://reviews.apache.org/r/12391/diff/
Testing
-------
Rendered each template that used the 'mesosDate' filter.
Thanks,
Ross Allen
Re: Review Request 12391: Format dates as ISO instead of American
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12391/#review22963
-----------------------------------------------------------
Ship it!
Thanks (from a Canadian)!
- Ben Mahler
On July 10, 2013, 1:56 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12391/
> -----------------------------------------------------------
>
> (Updated July 10, 2013, 1:56 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Log dates are printed as ISO, not the American format. This makes copying/pasting more straightforward.
>
>
> Diffs
> -----
>
> src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
>
> Diff: https://reviews.apache.org/r/12391/diff/
>
>
> Testing
> -------
>
> Rendered each template that used the 'mesosDate' filter.
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12391: Format dates as ISO instead of American
Posted by Ross Allen <ro...@mesosphe.re>.
> On July 10, 2013, 8:51 p.m., Benjamin Hindman wrote:
> > src/webui/master/static/app.js, line 32
> > <https://reviews.apache.org/r/12391/diff/1/?file=319511#file319511line32>
> >
> > s/mesosDate/isoDate/ ?
I had actually renamed it and then reverted since it was used in so many places. I wanted to keep this commit tiny.
I can rename the filter in another commit unless you think it should be done here?
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12391/#review22972
-----------------------------------------------------------
On July 10, 2013, 1:56 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12391/
> -----------------------------------------------------------
>
> (Updated July 10, 2013, 1:56 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Log dates are printed as ISO, not the American format. This makes copying/pasting more straightforward.
>
>
> Diffs
> -----
>
> src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
>
> Diff: https://reviews.apache.org/r/12391/diff/
>
>
> Testing
> -------
>
> Rendered each template that used the 'mesosDate' filter.
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12391: Format dates as ISO instead of American
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On July 10, 2013, 8:51 p.m., Benjamin Hindman wrote:
> > src/webui/master/static/app.js, line 32
> > <https://reviews.apache.org/r/12391/diff/1/?file=319511#file319511line32>
> >
> > s/mesosDate/isoDate/ ?
>
> Ross Allen wrote:
> I had actually renamed it and then reverted since it was used in so many places. I wanted to keep this commit tiny.
>
> I can rename the filter in another commit unless you think it should be done here?
Renames aren't usually too big a deal, so feel free to do it here.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12391/#review22972
-----------------------------------------------------------
On July 10, 2013, 1:56 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12391/
> -----------------------------------------------------------
>
> (Updated July 10, 2013, 1:56 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Log dates are printed as ISO, not the American format. This makes copying/pasting more straightforward.
>
>
> Diffs
> -----
>
> src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
>
> Diff: https://reviews.apache.org/r/12391/diff/
>
>
> Testing
> -------
>
> Rendered each template that used the 'mesosDate' filter.
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12391: Format dates as ISO instead of American
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12391/#review22972
-----------------------------------------------------------
Ship it!
src/webui/master/static/app.js
<https://reviews.apache.org/r/12391/#comment46762>
s/mesosDate/isoDate/ ?
- Benjamin Hindman
On July 10, 2013, 1:56 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12391/
> -----------------------------------------------------------
>
> (Updated July 10, 2013, 1:56 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Log dates are printed as ISO, not the American format. This makes copying/pasting more straightforward.
>
>
> Diffs
> -----
>
> src/webui/master/static/app.js 404516f8c760cdff564a9b1e8d2e0d74407daf67
>
> Diff: https://reviews.apache.org/r/12391/diff/
>
>
> Testing
> -------
>
> Rendered each template that used the 'mesosDate' filter.
>
>
> Thanks,
>
> Ross Allen
>
>