You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "dentiny (via GitHub)" <gi...@apache.org> on 2025/07/20 23:19:42 UTC
[I] Feature request: support set snapshot property [iceberg-rust]
dentiny opened a new issue, #1533:
URL: https://github.com/apache/iceberg-rust/issues/1533
### Is your feature request related to a problem or challenge?
A re-raise for https://github.com/apache/iceberg-rust/issues/1329.
Previously I only add the ability to `FastAppendAction`, but if people're doing other actions, we still don't have a way to set properties.
### Describe the solution you'd like
_No response_
### Willingness to contribute
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Feature request: support set snapshot property [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 closed issue #1533: Feature request: support set snapshot property
URL: https://github.com/apache/iceberg-rust/issues/1533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Feature request: support set snapshot property [iceberg-rust]
Posted by "dentiny (via GitHub)" <gi...@apache.org>.
dentiny commented on issue #1533:
URL: https://github.com/apache/iceberg-rust/issues/1533#issuecomment-3095299433
> I think the existing iceberg-rust only support `FastAppendAction` that will update the snapshot via snapshot producer, do you mean that we should add `set_snapshot_properties` when we add other snapshot-producing actions in the future?
Yes, actually I even prefer to have a separate action to update snapshot summary properties.
That said, a new transaction to create a new snapshot, with new summary properties and all other unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Feature request: support set snapshot property [iceberg-rust]
Posted by "dentiny (via GitHub)" <gi...@apache.org>.
dentiny commented on issue #1533:
URL: https://github.com/apache/iceberg-rust/issues/1533#issuecomment-3102136644
@liurenjie1024 I'm fine with you closing the ticket but would like to know if you have other suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Feature request: support set snapshot property [iceberg-rust]
Posted by "dentiny (via GitHub)" <gi...@apache.org>.
dentiny commented on issue #1533:
URL: https://github.com/apache/iceberg-rust/issues/1533#issuecomment-3097280566
> Do you have concrete use cases when this is useful? e.g. Updating snapshot properties without manipulating table data.
In [moonlink](https://github.com/Mooncake-Labs/moonlink), I did my own hack to implement compaction via self implemented catalog, which is possible to have only data files to delete, but nothing to add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Feature request: support set snapshot property [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 closed issue #1533: Feature request: support set snapshot property
URL: https://github.com/apache/iceberg-rust/issues/1533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Feature request: support set snapshot property [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on issue #1533:
URL: https://github.com/apache/iceberg-rust/issues/1533#issuecomment-3102124550
> > Do you have concrete use cases when this is useful? e.g. Updating snapshot properties without manipulating table data.
>
> In [moonlink](https://github.com/Mooncake-Labs/moonlink), we support compaction via self implemented catalog, which is possible to have only data files to delete, but nothing to add (which is not supported as of now).
Thanks @dentiny for this suggestion. But your use case makes me feel that adding a `SetSnapshotProperty` tx action is a workaround for the missing of some other tx actions. I have a big concern about this approach and don't think this is the right direction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Feature request: support set snapshot property [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on issue #1533:
URL: https://github.com/apache/iceberg-rust/issues/1533#issuecomment-3102129868
I'll close this as not planned for now as this is not what we want to do. Feel free to reopen it if anyone still wants more discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Feature request: support set snapshot property [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on issue #1533:
URL: https://github.com/apache/iceberg-rust/issues/1533#issuecomment-3096111269
> > I think the existing iceberg-rust only support `FastAppendAction` that will update the snapshot via snapshot producer, do you mean that we should add `set_snapshot_properties` when we add other snapshot-producing actions in the future?
>
> Yes, actually I even prefer to have a separate action to update snapshot summary properties. That said, a new transaction to create a new snapshot, with new summary properties and all other unchanged.
Do you have concrete use cases when this is useful? e.g. Updating snapshot properties without manipulating table data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Feature request: support set snapshot property [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on issue #1533:
URL: https://github.com/apache/iceberg-rust/issues/1533#issuecomment-3102178835
> [@liurenjie1024](https://github.com/liurenjie1024) I'm fine with you closing the ticket but would like to know if you have other suggestions?
Do you mean to set snapshot properties? I'm find with the method in #1534 as a temporary workaround for your use case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Feature request: support set snapshot property [iceberg-rust]
Posted by "CTTY (via GitHub)" <gi...@apache.org>.
CTTY commented on issue #1533:
URL: https://github.com/apache/iceberg-rust/issues/1533#issuecomment-3095259190
I think the existing iceberg-rust only support `FastAppendAction` that will update the snapshot via snapshot producer, do you mean that we should add `set_snapshot_properties` when we add other snapshot-producing actions in the future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Feature request: support set snapshot property [iceberg-rust]
Posted by "dentiny (via GitHub)" <gi...@apache.org>.
dentiny commented on issue #1533:
URL: https://github.com/apache/iceberg-rust/issues/1533#issuecomment-3102206827
> Do you mean to set snapshot properties?
Yes!
> I'm find with the method in [#1534](https://github.com/apache/iceberg-rust/pull/1534) as a temporary workaround for your use case.
Thank you! I'm also trying to reduce (unnecessary) code change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org