You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Wencong Liu (Jira)" <ji...@apache.org> on 2023/08/31 09:50:00 UTC
[jira] [Comment Edited] (FLINK-33009) tools/release/update_japicmp_configuration.sh should only enable binary compatibility checks in the release branch
[ https://issues.apache.org/jira/browse/FLINK-33009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760830#comment-17760830 ]
Wencong Liu edited comment on FLINK-33009 at 8/31/23 9:49 AM:
--------------------------------------------------------------
Thanks [~mapohl] for the summary.
BTW, I found this issue because I'm trying to add a new default method to an existed *@ Public* interface. Although this behavior shouldn't introduce source(or binary) incompatibility, it cannot pass the check.
I have reported this in the japicmp community. [New static method in interface detected as METHOD_NEW_DEFAULT · Issue #289 · siom79/japicmp (github.com)|https://github.com/siom79/japicmp/issues/289].
was (Author: JIRAUSER281639):
Thanks [~mapohl] for the summary.
BTW, I found this issue because I'm trying to add a new default method to an existed *@ Public* interface. Although this behavior shouldn't introduce binary or source incompatibility, it cannot pass the check.
I have reported this in the japicmp community. [New static method in interface detected as METHOD_NEW_DEFAULT · Issue #289 · siom79/japicmp (github.com)|https://github.com/siom79/japicmp/issues/289].
> tools/release/update_japicmp_configuration.sh should only enable binary compatibility checks in the release branch
> ------------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-33009
> URL: https://issues.apache.org/jira/browse/FLINK-33009
> Project: Flink
> Issue Type: Bug
> Components: Release System
> Affects Versions: 1.19.0
> Reporter: Matthias Pohl
> Priority: Major
>
> According to Flink's API compatibility constraints, we only support binary compatibility between versions. In [apache-flink:pom.xml:2246|https://github.com/apache/flink/blob/aa8d93ea239f5be79066b7e5caad08d966c86ab2/pom.xml#L2246] we have binary compatibility enabled even in {{master}}. This doesn't comply with the rules. We should this flag disabled in {{master}}. The {{tools/release/update_japicmp_configuration.sh}} should enable this flag in the release branch as part of the release process.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)