[GitHub] [iceberg] rdblue commented on a diff in pull request #5236: Build: Add iceberg-build.properties to Jars and release process

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5236:
URL: https://github.com/apache/iceberg/pull/5236#discussion_r917441564


##########
dev/source-release.sh:
##########
@@ -109,7 +110,11 @@ fi
 # archive (identical hashes) using the scm tag
 echo "Creating tarball ${tarball} using commit $release_hash"
 tarball=$tag.tar.gz
-git archive $release_hash --worktree-attributes --prefix $tag/ -o $projectdir/$tarball
+git archive $release_hash --worktree-attributes --prefix $tag/ --add-file $projectdir/version.txt --add-file $projectdir/iceberg-build.properties -o $projectdir/$tarball
+
+# remove the uncommitted build files so they don't affect the current working copy
+rm $projectdir/version.txt
+rm $projectdir/iceberg-build.properties

Review Comment:
   This wasn't needed before because the `version.txt` file was committed. When switching back to the master branch, it would be removed because it isn't present in the master branch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org