You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by patricklucas <gi...@git.apache.org> on 2018/01/29 13:30:09 UTC
[GitHub] flink pull request #5380: [hotfix][connectors] Fix log format strings
GitHub user patricklucas opened a pull request:
https://github.com/apache/flink/pull/5380
[hotfix][connectors] Fix log format strings
Log4j uses '{}' instead of '%s' for interpolating values, meaning these logging statements currently result in log entries with the literal string '%s' instead of a useful value.
I ran into the one in `FlinkKafkaProducer011.java`, but did a brief search in the `flink-connectors` module and found the others.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/patricklucas/flink fix_connector_log_statements
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5380.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5380
----
commit 2e6c69f599921b970ec2ca9ac4bf7b6858d25189
Author: Patrick Lucas <me...@...>
Date: 2018-01-29T12:58:09Z
[hotfix][connectors] Fix log format strings
Fixes three occurrences of using '%s' instead of '{}' in logging
statements.
----
---
[GitHub] flink pull request #5380: [hotfix][connectors] Fix log format strings
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5380
---
[GitHub] flink issue #5380: [hotfix][connectors] Fix log format strings
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5380
Please merge for `master` and `release-1.4`...
---
[GitHub] flink issue #5380: [hotfix][connectors] Fix log format strings
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/5380
LGTM, will merge this.
---