You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Junjie Peng (JIRA)" <ji...@apache.org> on 2008/07/09 11:11:31 UTC
[jira] Created: (DERBY-3767) Convert
"org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit.
Convert "org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit.
-------------------------------------------------------------------------------
Key: DERBY-3767
URL: https://issues.apache.org/jira/browse/DERBY-3767
Project: Derby
Issue Type: Test
Components: Test
Environment: windows xp, sp2.
Reporter: Junjie Peng
Assignee: Junjie Peng
Convert "org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3767) Convert
"org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit.
Posted by "Junjie Peng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Junjie Peng updated DERBY-3767:
-------------------------------
Attachment: derby-3767-1-stat.txt
derby-3767-1-patch.txt
The junit class NullsTest.java is different from nulls.sql from Line 121 to Line 130, which is accroding to Line 73 to Line 82 in nulls.sql. I think the codes in nulls.sql does not confirm with the author's intent. Please check it! Thank you!
> Convert "org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit.
> -------------------------------------------------------------------------------
>
> Key: DERBY-3767
> URL: https://issues.apache.org/jira/browse/DERBY-3767
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3767-1-patch.txt, derby-3767-1-stat.txt
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3767) Convert
"org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit.
Posted by "Junjie Peng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Junjie Peng updated DERBY-3767:
-------------------------------
Attachment: derby-3767-2-stat.txt
derby-3767-2-patch.txt
Yes, Bryan, I agree with you. It seems better.
Please check the derby-3767-2-patch. Thank you!
> Convert "org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit.
> -------------------------------------------------------------------------------
>
> Key: DERBY-3767
> URL: https://issues.apache.org/jira/browse/DERBY-3767
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3767-1-patch.txt, derby-3767-1-stat.txt, derby-3767-2-patch.txt, derby-3767-2-stat.txt
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3767) Convert
"org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit.
Posted by "Junjie Peng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Junjie Peng updated DERBY-3767:
-------------------------------
Derby Info: [Patch Available]
> Convert "org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit.
> -------------------------------------------------------------------------------
>
> Key: DERBY-3767
> URL: https://issues.apache.org/jira/browse/DERBY-3767
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3767-1-patch.txt, derby-3767-1-stat.txt
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3767) Convert
"org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit.
Posted by "Junjie Peng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613871#action_12613871 ]
Junjie Peng commented on DERBY-3767:
------------------------------------
OK, I will review it. Thank you, Kathey!
> Convert "org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit.
> -------------------------------------------------------------------------------
>
> Key: DERBY-3767
> URL: https://issues.apache.org/jira/browse/DERBY-3767
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3767-1-patch.txt, derby-3767-1-stat.txt
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3767) Convert
"org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit.
Posted by "Junjie Peng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613883#action_12613883 ]
Junjie Peng commented on DERBY-3767:
------------------------------------
I'm still not so clear.
This is code from Line 72 to Line 82 in nulls.sql,
"
-- try with multiple null columns
create table a (a1 int not null, a2 int, a3 int);
insert into a values(1,1,1);
-- table with no null data should work
alter table a add constraint ap1 primary key(a1, a2, a3);
-- insert a null into one of the primary key columns should fail
insert into a values(1, NULL, 1);
drop table a;
"
It's expected
{
-- table with no null data should work
alter table a add constraint ap1 primary key(a1, a2, a3);
}
but this line fails in my ij.
And it's expected
{
-- insert a null into one of the primary key columns should fail
insert into a values(1, NULL, 1);
}
but this line is OK in my ij.
Besides, if the create sentence is "create table a (a1 int not null, a2 int not null, a3 int not null)"-----which is consistent with your new comments "-- try with multiple non-null columns.
", It will run as the comments expected. Is it suitable?
> Convert "org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit.
> -------------------------------------------------------------------------------
>
> Key: DERBY-3767
> URL: https://issues.apache.org/jira/browse/DERBY-3767
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3767-1-patch.txt, derby-3767-1-stat.txt
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3767) Convert
"org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit.
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612590#action_12612590 ]
Kathey Marsden commented on DERBY-3767:
---------------------------------------
This issue is marked patch available, but I don't see the patch.
> Convert "org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit.
> -------------------------------------------------------------------------------
>
> Key: DERBY-3767
> URL: https://issues.apache.org/jira/browse/DERBY-3767
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3767) Convert
"org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit.
Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613602#action_12613602 ]
Kathey Marsden commented on DERBY-3767:
---------------------------------------
nulls needs to be removed from LangScripts.
you need a license header.
I think it is best to stick with the same sql as in the script but fix the comment to match what is being tested. I think it is the comment
-- try with multiple null columns
which should I think be
-- try with multiple non-null columns.
> Convert "org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit.
> -------------------------------------------------------------------------------
>
> Key: DERBY-3767
> URL: https://issues.apache.org/jira/browse/DERBY-3767
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3767-1-patch.txt, derby-3767-1-stat.txt
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-3767) Convert
"org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit.
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Myrna van Lunteren resolved DERBY-3767.
---------------------------------------
Resolution: Fixed
Fix Version/s: 10.5.0.0
Derby Info: (was: [Patch Available])
Kathey committed the latest patch with revisions 684823 and 684848
> Convert "org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit.
> -------------------------------------------------------------------------------
>
> Key: DERBY-3767
> URL: https://issues.apache.org/jira/browse/DERBY-3767
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Fix For: 10.5.0.0
>
> Attachments: derby-3767-1-patch.txt, derby-3767-1-stat.txt, derby-3767-2-patch.txt, derby-3767-2-stat.txt
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3767) Convert
"org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit.
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613958#action_12613958 ]
Bryan Pendleton commented on DERBY-3767:
----------------------------------------
Try adding the following:
alter table a alter column a2 not null;
alter table a alter column a3 not null;
Immediately before the "alter table add constraint" line.
In order for a column to be a member of a primary key,
the column must be marked as "not null" first.
With that change in place, does the test seem to make more sense?
> Convert "org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit.
> -------------------------------------------------------------------------------
>
> Key: DERBY-3767
> URL: https://issues.apache.org/jira/browse/DERBY-3767
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3767-1-patch.txt, derby-3767-1-stat.txt
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3767) Convert
"org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit.
Posted by "Junjie Peng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Junjie Peng updated DERBY-3767:
-------------------------------
Derby Info: (was: [Patch Available])
I'm sorry, it's a mistake. The patch is in process. Thanks for attention.
> Convert "org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit.
> -------------------------------------------------------------------------------
>
> Key: DERBY-3767
> URL: https://issues.apache.org/jira/browse/DERBY-3767
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.nulls.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.