You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/09/09 21:35:43 UTC
[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request
#2571: [GOBBLIN-701] Added the concept of secure job templates and job
resolution callbacks.
sv2000 commented on a change in pull request #2571: [GOBBLIN-701] Added the concept of secure job templates and job resolution callbacks.
URL: https://github.com/apache/incubator-gobblin/pull/2571#discussion_r322449453
##########
File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/template/StaticJobTemplate.java
##########
@@ -105,6 +114,17 @@ protected Config getLocalRawTemplate() {
@Override
protected Config getLocallyResolvedConfig(Config userConfig) {
- return userConfig.withFallback(this.rawConfig);
+ Config filteredUserConfig = SecureJobTemplate.filterUserConfig(this, userConfig, log);
+ return filteredUserConfig.withFallback(this.rawConfig);
+ }
+
+ @Override
+ public boolean isSecure() {
+ return this.rawConfig.hasPath(IS_SECURE_KEY) && this.rawConfig.getBoolean(IS_SECURE_KEY);
Review comment:
ConfigUtils.getBoolean(rawConfig, IS_SECURE_KEY, false)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services