You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/05 03:51:19 UTC
[GitHub] [pulsar] liangyepianzhou opened a new pull request #12636: Stop tb recovering with exception
liangyepianzhou opened a new pull request #12636:
URL: https://github.com/apache/pulsar/pull/12636
### Motivation
When TransactionBuffer recoversing, if any ledger was deleted from bookkeeper, or ManagerLedger was fenced, TtransactionBuffer will not stop recovering and continue to report the exception.
### Modifications
End recovering when there is no ledger to read or the managerLedger is fenced.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
- [x] `no-need-doc`
Bug Fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyepianzhou commented on pull request #12636: [Transaction]Stop TB recovering with exception
Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on pull request #12636:
URL: https://github.com/apache/pulsar/pull/12636#issuecomment-962404540
There is a problem here:
When a NonRecoverableLedgerException appears, do we need to move the cusor in the FillEntryQueueCallback of TransactionBufferd or directly end this recoveration?
When I was writing the test, I found that readEntriesFailed in FillEntryQueueCallback of TransactionBufferd was not called at all when this exception occurred. Later I found that when a NonRecoverableLedgerException occurs, OpReadEntry will process and move the cusor, and only when there is no a nextReadPosition will readEntriesFailed in FillEntryQueueCallback of TransactionBufferd be called.
So I think the recover can be ended directly, there is no problem with the previous implementation.
Do you think so? @ @codelipenghui @congbobo184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 merged pull request #12636: [Transaction]Stop TB recovering with exception
Posted by GitBox <gi...@apache.org>.
congbobo184 merged pull request #12636:
URL: https://github.com/apache/pulsar/pull/12636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyepianzhou commented on pull request #12636: Stop tb recovering with exception
Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on pull request #12636:
URL: https://github.com/apache/pulsar/pull/12636#issuecomment-962399102
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyepianzhou removed a comment on pull request #12636: [Transaction]Stop TB recovering with exception
Posted by GitBox <gi...@apache.org>.
liangyepianzhou removed a comment on pull request #12636:
URL: https://github.com/apache/pulsar/pull/12636#issuecomment-962404540
There is a problem here:
When a NonRecoverableLedgerException appears, do we need to move the cusor in the FillEntryQueueCallback of TransactionBufferd or directly end this recoveration?
When I was writing the test, I found that readEntriesFailed in FillEntryQueueCallback of TransactionBufferd was not called at all when this exception occurred. Later I found that when a NonRecoverableLedgerException occurs, OpReadEntry will process and move the cusor, and only when there is no a nextReadPosition will readEntriesFailed in FillEntryQueueCallback of TransactionBufferd be called.
So I think the recover can be ended directly, there is no problem with the previous implementation.
Do you think so? @ @codelipenghui @congbobo184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org