[GitHub] [tvm] junrushao1994 commented on a diff in pull request #11585: [TIR] Add preserve-unit-iters

[GitBox <gi...@apache.org>]

junrushao1994 commented on code in PR #11585:
URL: https://github.com/apache/tvm/pull/11585#discussion_r889786119


##########
include/tvm/tir/schedule/schedule.h:
##########
@@ -277,19 +277,22 @@ class ScheduleNode : public runtime::Object {
    * 3) All loops must start with 0.
    * 4) The domain of a loop to be fused cannot depend on another loop to be fused.
    * \param loop_rvs The loops to be fused
+   * \param preserve_unit_iters Whether or not to preserve unit iterators in block bindings
    * \return The new loop after fusion
    */
-  virtual LoopRV Fuse(const Array<LoopRV>& loop_rvs) = 0;
+  virtual LoopRV Fuse(const Array<LoopRV>& loop_rvs, bool preserve_unit_iters = true) = 0;

Review Comment:
   Usually it doesn't affect usability if we don't over-simplify anything though...but i don't have strong opinion on what a good default should be



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org