You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/04/22 17:30:35 UTC
Review Request 33440: RU: Add manual step with message for skipped
services
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33440/
-----------------------------------------------------------
Review request for Ambari and Alejandro Fernandez.
Bugs: AMBARI-10662
https://issues.apache.org/jira/browse/AMBARI-10662
Repository: ambari
Description
-------
Original task:
Before finalizing, list any services that failed and the user clicked on "Skip". If any services were skipped, confirm the list again right before beginning the clients.
For the latter requirement, we decided to add a manual step. UI will customize the message with custom formatting and skipped services list (similarly to what we do for the Finalize step).
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 0cf8ff2
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 8dccf65
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 65549dd
Diff: https://reviews.apache.org/r/33440/diff/
Testing
-------
manual
Thanks,
Dmitro Lisnichenko
Re: Review Request 33440: RU: Add manual step with message for skipped
services
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On April 22, 2015, 5:37 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml, line 176
> > <https://reviews.apache.org/r/33440/diff/1/?file=939552#file939552line176>
> >
> > Any way we can display a list of them in the message?
If not, that's fine.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33440/#review81178
-----------------------------------------------------------
On April 22, 2015, 3:30 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33440/
> -----------------------------------------------------------
>
> (Updated April 22, 2015, 3:30 p.m.)
>
>
> Review request for Ambari and Alejandro Fernandez.
>
>
> Bugs: AMBARI-10662
> https://issues.apache.org/jira/browse/AMBARI-10662
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Original task:
> Before finalizing, list any services that failed and the user clicked on "Skip". If any services were skipped, confirm the list again right before beginning the clients.
>
> For the latter requirement, we decided to add a manual step. UI will customize the message with custom formatting and skipped services list (similarly to what we do for the Finalize step).
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 0cf8ff2
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 8dccf65
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 65549dd
>
> Diff: https://reviews.apache.org/r/33440/diff/
>
>
> Testing
> -------
>
> manual
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 33440: RU: Add manual step with message for skipped
services
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On April 22, 2015, 5:37 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml, line 176
> > <https://reviews.apache.org/r/33440/diff/1/?file=939552#file939552line176>
> >
> > Any way we can display a list of them in the message?
>
> Alejandro Fernandez wrote:
> If not, that's fine.
As of now, no. UI will provide the proper text just like we do for Finalize step (we have a relevant UI jira for that), and also an advanced formatting.
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33440/#review81178
-----------------------------------------------------------
On April 22, 2015, 3:30 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33440/
> -----------------------------------------------------------
>
> (Updated April 22, 2015, 3:30 p.m.)
>
>
> Review request for Ambari and Alejandro Fernandez.
>
>
> Bugs: AMBARI-10662
> https://issues.apache.org/jira/browse/AMBARI-10662
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Original task:
> Before finalizing, list any services that failed and the user clicked on "Skip". If any services were skipped, confirm the list again right before beginning the clients.
>
> For the latter requirement, we decided to add a manual step. UI will customize the message with custom formatting and skipped services list (similarly to what we do for the Finalize step).
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 0cf8ff2
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 8dccf65
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 65549dd
>
> Diff: https://reviews.apache.org/r/33440/diff/
>
>
> Testing
> -------
>
> manual
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 33440: RU: Add manual step with message for skipped
services
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33440/#review81178
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml
<https://reviews.apache.org/r/33440/#comment131433>
Any way we can display a list of them in the message?
- Alejandro Fernandez
On April 22, 2015, 3:30 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33440/
> -----------------------------------------------------------
>
> (Updated April 22, 2015, 3:30 p.m.)
>
>
> Review request for Ambari and Alejandro Fernandez.
>
>
> Bugs: AMBARI-10662
> https://issues.apache.org/jira/browse/AMBARI-10662
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Original task:
> Before finalizing, list any services that failed and the user clicked on "Skip". If any services were skipped, confirm the list again right before beginning the clients.
>
> For the latter requirement, we decided to add a manual step. UI will customize the message with custom formatting and skipped services list (similarly to what we do for the Finalize step).
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 0cf8ff2
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 8dccf65
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 65549dd
>
> Diff: https://reviews.apache.org/r/33440/diff/
>
>
> Testing
> -------
>
> manual
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 33440: RU: Add manual step with message for skipped
services
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33440/#review81183
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On April 22, 2015, 3:30 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33440/
> -----------------------------------------------------------
>
> (Updated April 22, 2015, 3:30 p.m.)
>
>
> Review request for Ambari and Alejandro Fernandez.
>
>
> Bugs: AMBARI-10662
> https://issues.apache.org/jira/browse/AMBARI-10662
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Original task:
> Before finalizing, list any services that failed and the user clicked on "Skip". If any services were skipped, confirm the list again right before beginning the clients.
>
> For the latter requirement, we decided to add a manual step. UI will customize the message with custom formatting and skipped services list (similarly to what we do for the Finalize step).
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 0cf8ff2
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 8dccf65
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 65549dd
>
> Diff: https://reviews.apache.org/r/33440/diff/
>
>
> Testing
> -------
>
> manual
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>