[GitHub] [accumulo] cshannon commented on a diff in pull request #3257: Refactor TabletMetadata.Location to encapsulate TServerInstance

["cshannon (via GitHub)" <gi...@apache.org>]

cshannon commented on code in PR #3257:
URL: https://github.com/apache/accumulo/pull/3257#discussion_r1147951907


##########
server/base/src/main/java/org/apache/accumulo/server/manager/state/MetaDataStateStore.java:
##########
@@ -62,10 +62,10 @@ public void setLocations(Collection<Assignment> assignments) throws DistributedS
     try (var tabletsMutator = ample.mutateTablets()) {
       for (Assignment assignment : assignments) {
         TabletMutator tabletMutator = tabletsMutator.mutateTablet(assignment.tablet);
-        tabletMutator.putLocation(assignment.server, LocationType.CURRENT);
+        tabletMutator.putLocation(TabletMetadata.Location.current(assignment.server));

Review Comment:
   Yeah I agree, it would be even nicer/cleaner if we imported Location



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org