You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/03/14 08:14:39 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #5151: Fix the SQL
group-by for empty data table
codecov-io commented on issue #5151: Fix the SQL group-by for empty data table
URL: https://github.com/apache/incubator-pinot/pull/5151#issuecomment-599026653
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5151?src=pr&el=h1) Report
> Merging [#5151](https://codecov.io/gh/apache/incubator-pinot/pull/5151?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/888700d436668f58abe45ddd2696e859a5458dca?src=pr&el=desc) will **decrease** coverage by `20.38%`.
> The diff coverage is `97.61%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5151?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5151 +/- ##
=============================================
- Coverage 65.55% 45.16% -20.39%
=============================================
Files 1052 1052
Lines 54136 54151 +15
Branches 8080 8081 +1
=============================================
- Hits 35489 24459 -11030
- Misses 16029 27578 +11549
+ Partials 2618 2114 -504
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5151?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...not/core/query/reduce/GroupByDataTableReducer.java](https://codecov.io/gh/apache/incubator-pinot/pull/5151/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvR3JvdXBCeURhdGFUYWJsZVJlZHVjZXIuamF2YQ==) | `65.86% <ø> (-21.17%)` | `0 <0> (ø)` | |
| [...t/core/query/reduce/SelectionDataTableReducer.java](https://codecov.io/gh/apache/incubator-pinot/pull/5151/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvU2VsZWN0aW9uRGF0YVRhYmxlUmVkdWNlci5qYXZh) | `76.36% <100%> (+0.5%)` | `0 <0> (ø)` | :arrow_down: |
| [...aggregation/function/AggregationFunctionUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5151/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9BZ2dyZWdhdGlvbkZ1bmN0aW9uVXRpbHMuamF2YQ==) | `95.23% <100%> (+0.11%)` | `0 <0> (ø)` | :arrow_down: |
| [...e/pinot/core/query/reduce/BrokerReduceService.java](https://codecov.io/gh/apache/incubator-pinot/pull/5151/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvQnJva2VyUmVkdWNlU2VydmljZS5qYXZh) | `89.18% <100%> (+0.19%)` | `0 <0> (ø)` | :arrow_down: |
| [...core/query/executor/ServerQueryExecutorV1Impl.java](https://codecov.io/gh/apache/incubator-pinot/pull/5151/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9leGVjdXRvci9TZXJ2ZXJRdWVyeUV4ZWN1dG9yVjFJbXBsLmphdmE=) | `79.28% <100%> (-0.72%)` | `0 <0> (ø)` | |
| [.../pinot/core/common/datatable/DataTableBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/5151/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vZGF0YXRhYmxlL0RhdGFUYWJsZUJ1aWxkZXIuamF2YQ==) | `74.19% <100%> (-6.04%)` | `0 <0> (ø)` | |
| [...he/pinot/core/common/datatable/DataTableUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5151/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vZGF0YXRhYmxlL0RhdGFUYWJsZVV0aWxzLmphdmE=) | `93.1% <96.96%> (+12.15%)` | `0 <0> (ø)` | :arrow_down: |
| [.../org/apache/pinot/common/http/MultiGetRequest.java](https://codecov.io/gh/apache/incubator-pinot/pull/5151/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vaHR0cC9NdWx0aUdldFJlcXVlc3QuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...che/pinot/common/restlet/resources/TablesList.java](https://codecov.io/gh/apache/incubator-pinot/pull/5151/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVzdGxldC9yZXNvdXJjZXMvVGFibGVzTGlzdC5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| [...ransformer/timeunit/CustomTimeUnitTransformer.java](https://codecov.io/gh/apache/incubator-pinot/pull/5151/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vdHJhbnNmb3JtZXIvdGltZXVuaXQvQ3VzdG9tVGltZVVuaXRUcmFuc2Zvcm1lci5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
| ... and [565 more](https://codecov.io/gh/apache/incubator-pinot/pull/5151/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5151?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5151?src=pr&el=footer). Last update [888700d...fb05265](https://codecov.io/gh/apache/incubator-pinot/pull/5151?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org