You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/07/24 17:28:26 UTC
Review Request 68033: Fixed flaky test
`DefaultExecutorTest.TaskWithFileURI`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68033/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-9108
https://issues.apache.org/jira/browse/MESOS-9108
Repository: mesos
Description
-------
Fixed the flay test by removing the last scheduler task
status acknowledgment which could race with the test
tear-down (including the scheduler destruction).
Diffs
-----
src/tests/default_executor_tests.cpp f23cb07fbdc9dac0acf75714c835e0eedd7dce6f
Diff: https://reviews.apache.org/r/68033/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 68033: Fixed flaky test
`DefaultExecutorTest.TaskWithFileURI`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68033/#review206412
-----------------------------------------------------------
PASS: Mesos patch 68033 was successfully built and tested.
Reviews applied: `['68033']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1974/mesos-review-68033
- Mesos Reviewbot Windows
On July 24, 2018, 5:28 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68033/
> -----------------------------------------------------------
>
> (Updated July 24, 2018, 5:28 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-9108
> https://issues.apache.org/jira/browse/MESOS-9108
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed the flay test by removing the last scheduler task
> status acknowledgment which could race with the test
> tear-down (including the scheduler destruction).
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp f23cb07fbdc9dac0acf75714c835e0eedd7dce6f
>
>
> Diff: https://reviews.apache.org/r/68033/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 68033: Fixed flaky test
`DefaultExecutorTest.TaskWithFileURI`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68033/#review206522
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68033]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 24, 2018, 10:28 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68033/
> -----------------------------------------------------------
>
> (Updated July 24, 2018, 10:28 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-9108
> https://issues.apache.org/jira/browse/MESOS-9108
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed the flay test by removing the last scheduler task
> status acknowledgment which could race with the test
> tear-down (including the scheduler destruction).
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp f23cb07fbdc9dac0acf75714c835e0eedd7dce6f
>
>
> Diff: https://reviews.apache.org/r/68033/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>