You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/07 01:14:03 UTC
[GitHub] [shardingsphere] FlyingZC commented on a diff in pull request #20770: Support using disabled data source at startup(#20738)
FlyingZC commented on code in PR #20770:
URL: https://github.com/apache/shardingsphere/pull/20770#discussion_r964295422
##########
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/datasource/state/DataSourceStateManager.java:
##########
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.infra.datasource.state;
+
+import lombok.AccessLevel;
+import lombok.NoArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.shardingsphere.infra.config.database.DatabaseConfiguration;
+import org.apache.shardingsphere.infra.datasource.state.exception.DataSourceStateException;
+
+import javax.sql.DataSource;
+import java.sql.Connection;
+import java.sql.SQLException;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.LinkedHashMap;
+import java.util.Map;
+import java.util.Map.Entry;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * Data source state manager.
+ */
+@Slf4j
+@NoArgsConstructor(access = AccessLevel.PRIVATE)
+public final class DataSourceStateManager {
+
+ private static final DataSourceStateManager INSTANCE = new DataSourceStateManager();
+
+ private final Map<String, DataSourceState> dataSourceStates = new ConcurrentHashMap<>();
+
+ private volatile boolean force;
+
+ private volatile boolean initialized;
+
+ /**
+ * Get data source state manager.
+ *
+ * @return data source state manager
+ */
+ public static DataSourceStateManager getInstance() {
+ return INSTANCE;
+ }
+
+ /**
+ * Set data source states when bootstrap.
+ *
+ * @param databaseName database name
+ * @param dataSources data sources
+ * @param storageDataSourceStates storage node data source status
+ * @param force whether to force start
+ */
+ public void initStates(final String databaseName, final Map<String, DataSource> dataSources, final Map<String, DataSourceState> storageDataSourceStates, final boolean force) {
+ this.force = force;
+ dataSources.forEach((key, value) -> {
+ DataSourceState storageState = storageDataSourceStates.get(getCacheKey(databaseName, key));
+ if (DataSourceState.DISABLED == storageState) {
+ dataSourceStates.put(getCacheKey(databaseName, key), storageState);
+ } else {
+ try (Connection ignored = value.getConnection()) {
+ dataSourceStates.put(getCacheKey(databaseName, key), DataSourceState.ENABLED);
+ } catch (final SQLException ex) {
+ if (this.force) {
+ log.error("Data source status unavailable, ignored with the -f parameter.", ex);
+ } else {
+ throw new DataSourceStateException("DataSourceState", 1, "Data source status unavailable.", ex);
+ }
+ }
+ }
+ });
+ initialized = true;
+ }
+
+ /**
+ * Filter disabled data sources.
+ *
+ * @param databaseConfigs database config
+ * @return data sources in a non-disabled state
+ */
+ public Collection<DataSource> getNonDisabledDataSources(final Map<String, ? extends DatabaseConfiguration> databaseConfigs) {
+ String databaseName = "";
+ Map<String, DataSource> dataSources = Collections.emptyMap();
+ for (Entry<String, ? extends DatabaseConfiguration> entry : databaseConfigs.entrySet()) {
+ DatabaseConfiguration value = entry.getValue();
+ if (!value.getDataSources().isEmpty()) {
+ databaseName = entry.getKey();
+ dataSources = value.getDataSources();
+ break;
+ }
+ }
+ return dataSources.isEmpty() ? dataSources.values() : filterDisabledDataSources(databaseName, dataSources).values();
+ }
+
+ /**
+ * Filter disabled data sources.
+ *
+ * @param databaseName database name
+ * @param databaseConfig database config
+ * @return data sources in a non-disabled state
+ */
+ public Collection<DataSource> getNonDisabledDataSources(final String databaseName, final DatabaseConfiguration databaseConfig) {
+ return databaseConfig.getDataSources().isEmpty() ? Collections.emptyList() : filterDisabledDataSources(databaseName, databaseConfig.getDataSources()).values();
+ }
+
+ /**
+ * Filter disabled data sources.
+ *
+ * @param databaseName database name
+ * @param dataSources data sources
+ * @return data sources in a non-disabled state
+ */
+ public Map<String, DataSource> filterDisabledDataSources(final String databaseName, final Map<String, DataSource> dataSources) {
+ if (dataSources.isEmpty() || !initialized) {
+ return dataSources;
+ }
+ Map<String, DataSource> result = new LinkedHashMap<>(dataSources.size(), 1);
+ if (force) {
+ dataSources.forEach((key, value) -> {
+ if (DataSourceState.ENABLED == dataSourceStates.get(getCacheKey(databaseName, key))) {
+ result.put(key, value);
+ }
+ });
+ } else {
+ dataSources.forEach((key, value) -> {
+ if (DataSourceState.DISABLED != dataSourceStates.get(getCacheKey(databaseName, key))) {
+ result.put(key, value);
+ }
+ });
+ }
+ return result;
+ }
+
+ private String getCacheKey(final String databaseName, final String key) {
+ return databaseName + "." + key;
Review Comment:
Your are right.
##########
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/datasource/state/DataSourceState.java:
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.infra.datasource.state;
+
+/**
+ * Data source state.
+ */
+public enum DataSourceState {
+
+ DISABLED, ENABLED;
+
+ /**
+ * Data source disable or enable.
+ *
+ * @param status data source state
+ * @return disable or enable
+ */
+ public static boolean isDisable(final String status) {
+ return DISABLED.name().toLowerCase().equals(status);
+ }
+
+ /**
+ * Data source disable or enable.
+ *
+ * @param status storage node status
+ * @return disable or enable
+ */
+ public static boolean isEnable(final String status) {
+ return ENABLED.name().toLowerCase().equals(status);
+ }
+
+ /**
+ * Get data source state by state name.
+ *
+ * @param state data source state name
+ * @return data source state
+ */
+ public static DataSourceState getDataSourceState(final String state) {
+ for (DataSourceState each : values()) {
+ if (each.name().equalsIgnoreCase(state)) {
+ return each;
+ }
+ }
+ return null;
Review Comment:
Your are right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org