You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2019/07/01 13:12:54 UTC

[GitHub] [libcloud] Kami commented on a change in pull request #1300: ec2 list_volumes should accept more filters

Kami commented on a change in pull request #1300: ec2 list_volumes should accept more filters
URL: https://github.com/apache/libcloud/pull/1300#discussion_r299035306
 
 

 ##########
 File path: libcloud/compute/drivers/ec2.py
 ##########
 @@ -1783,12 +1783,28 @@ def list_locations(self):
             )
         return locations
 
-    def list_volumes(self, node=None):
+    def list_volumes(self, node=None, filters=None):
 
 Review comment:
   Since it's an extension argument please rename it to ``ex_filters``.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services