You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "liaorui (via GitHub)" <gi...@apache.org> on 2023/03/02 16:02:06 UTC
[GitHub] [inlong] liaorui opened a new pull request, #7505: [INLONG-7504][Sort][]fix NPE when dirty ignore is false
liaorui opened a new pull request, #7505:
URL: https://github.com/apache/inlong/pull/7505
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Title Example: [INLONG-XYZ][Component] Title of the pull request
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
- Fixes #7504
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
StarRocks will throw NullPointerException when dirty.ignore is false.
### Modifications
*Describe the modifications you've done.*
Check if null when parsing dirty.label, dirty.logtag and dirty.identifier in class `StarRocksDynamicSinkFunction`.
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gong commented on pull request #7505: [INLONG-7504][Sort] Fix NPE when dirty ignore is false
Posted by "gong (via GitHub)" <gi...@apache.org>.
gong commented on PR #7505:
URL: https://github.com/apache/inlong/pull/7505#issuecomment-1452996900
Maybe It is common problems. We need check other sink connector
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] EMsnap merged pull request #7505: [INLONG-7504][Sort] Fix NPE when dirty ignore is false
Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap merged PR #7505:
URL: https://github.com/apache/inlong/pull/7505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] liaorui commented on pull request #7505: [INLONG-7504][Sort] Fix NPE when dirty ignore is false
Posted by "liaorui (via GitHub)" <gi...@apache.org>.
liaorui commented on PR #7505:
URL: https://github.com/apache/inlong/pull/7505#issuecomment-1453022861
>
StarRock connector has fixed this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org