You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Sergey Grebnov (JIRA)" <ji...@apache.org> on 2015/10/19 11:14:05 UTC

[jira] [Updated] (CB-9821) Fix EventEmitter incorrect trace level usages

     [ https://issues.apache.org/jira/browse/CB-9821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sergey Grebnov updated CB-9821:
-------------------------------
    Summary: Fix EventEmitter incorrect trace level usages  (was: Fix EventEmitter wrong usages)

> Fix EventEmitter incorrect trace level usages
> ---------------------------------------------
>
>                 Key: CB-9821
>                 URL: https://issues.apache.org/jira/browse/CB-9821
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>            Reporter: Sergey Grebnov
>            Assignee: Sergey Grebnov
>              Labels: cordova-lib
>
> I see some places where we use incorrect log level argument, like 'err' or 'debug' so those traces are ignored and not displayed or could be intercepted by CordovaCLI/Plugman or other tools. 
> For example (we don't support 'debug'; the correct argument here is 'verbose'):
> {code}
> function getPluginsHookScripts(hook, opts) {
>     // args check
>     if (!hook) {
>         throw new Error('hook type is not specified');
>     }
>     // In case before_plugin_install, after_plugin_install, before_plugin_uninstall hooks we receive opts.plugin and
>     // retrieve scripts exclusive for this plugin.
>     if(opts.plugin) {
>         events.emit('debug', 'Executing "' + hook + '"  hook for "' + opts.plugin.id + '" on ' + opts.plugin.platform + '.');
>         // if plugin hook is not run for specific platform then use all available platforms
>         return getPluginScriptFiles(opts.plugin, hook, opts.plugin.platform  ? [opts.plugin.platform] : opts.cordova.platforms);
>     }
>     events.emit('debug', 'Executing "' + hook + '"  hook for all plugins.');
>     return getAllPluginsHookScriptFiles(hook, opts);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org