You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by Jaskey <gi...@git.apache.org> on 2017/04/25 04:47:14 UTC
[GitHub] incubator-rocketmq pull request #98: [ROCKETMQ-188]RemotingExecption is not ...
GitHub user Jaskey opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/98
[ROCKETMQ-188]RemotingExecption is not consistent between invoke async and invoke oneway
JIRA: https://issues.apache.org/jira/browse/ROCKETMQ-188
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jaskey/incubator-rocketmq ROCKETMQ-188-remoting-exception-inconsistent
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/98.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #98
----
commit ec2d4ac140fab8812066a7184f9e21ea0b879191
Author: Jaskey <li...@gmail.com>
Date: 2017-04-25T03:00:51Z
Make exception of invokeAsync is consitent of invokeOneway
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #98: [ROCKETMQ-188]RemotingExecption is not ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/98
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #98: [ROCKETMQ-188]RemotingExecption is not consist...
Posted by Jaskey <gi...@git.apache.org>.
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/98
@lizhanhui @zhouxinyu @shroman
guys, anyone helps review this pr?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #98: [ROCKETMQ-188]RemotingExecption is not consist...
Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/98
LGTM~, thanks @Jaskey
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #98: [ROCKETMQ-188]RemotingExecption is not consist...
Posted by dongeforever <gi...@git.apache.org>.
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/98
LGTM @zhouxinyu @vongosling
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #98: [ROCKETMQ-188]RemotingExecption is not consist...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/98
[](https://coveralls.io/builds/11225316)
Coverage increased (+0.04%) to 37.893% when pulling **ec2d4ac140fab8812066a7184f9e21ea0b879191 on Jaskey:ROCKETMQ-188-remoting-exception-inconsistent** into **6a9628b3c3e6835e37baf7b58ad9300364d4d384 on apache:develop**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---