You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by David Glasser <gl...@mit.edu> on 2006/10/31 19:18:06 UTC
Re: svn commit: r22181 - trunk/subversion/libsvn_client
On 10/31/06, rooneg@tigris.org <ro...@tigris.org> wrote:
> Log:
> Fix prop_tests.py number 16 over DAV by correcting the editor drive used
> in the propset to URL code.
>
> * subversion/libsvn_client/prop_commands.c
> (do_url_propset): Close the file and directory batons before returning,
> don't bother opening an extra directory baton for the directory case,
> the root baton works just fine and is already open to the right place.
Ack! Sorry about that.
Do you have any idea about why it worked with some ra backends and not others?
--dave
--
David Glasser | glasser@mit.edu | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r22181 - trunk/subversion/libsvn_client
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
On 10/31/06, Garrett Rooney <ro...@electricjellyfish.net> wrote:
> In ra_local and ra_svn the propchanges are actually done right at the
> change_dir_prop or change_file_prop call. For ra_dav it queues them
> up and does a single PROPPATCH request at the end of the file/dir, so
> if you don't actually close the file/dir it never happens.
FWIW, ra_serf got bit by the same bug. (prop tests #16 now passes
with ra_serf too.)
Glad to see failures go away without code in ra_serf being at fault.
;-) -- justin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r22181 - trunk/subversion/libsvn_client
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 10/31/06, David Glasser <gl...@mit.edu> wrote:
> Ack! Sorry about that.
>
> Do you have any idea about why it worked with some ra backends and not others?
In ra_local and ra_svn the propchanges are actually done right at the
change_dir_prop or change_file_prop call. For ra_dav it queues them
up and does a single PROPPATCH request at the end of the file/dir, so
if you don't actually close the file/dir it never happens.
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org