You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by pieter <pi...@gmail.com> on 2015/09/05 22:52:44 UTC
Groovy tests failing
Hi,
I am executing the GroovyProcessStandardSuite for the first time and
there are 2 failing tests.
GroovyStoreTest.get_g_VX1X_storeXaX_byXnameX_out_storeXaX_byXnameX_name_capXaX
GroovyRepeatTest.get_g_VX1X_repeatXoutX_untilXoutE_count_isX0XX_name
Both are failing because of the string interpolation,
"g.V(${v1Id})....."
in sqlg's case ${v1id} returns a string that is invalid groovy,
"g.V(PUBLIC.person:::0)...."
If it is wrapped in single quotes then all is fine.
Shall I just opt out of the test, or should the test be smarter as it is
assuming a numeric id?
Thanks
Pieter
Re: Groovy tests failing
Posted by Stephen Mallette <sp...@gmail.com>.
done:
https://github.com/apache/incubator-tinkerpop/commit/187ea93f61158ef56139a2a0efa1446fef0a48a3
On Tue, Sep 8, 2015 at 8:20 AM, pieter-gmail <pi...@gmail.com>
wrote:
> I won't get time to do a PR till the weekend, so might as well do it
> directly.
>
> Cheers
> Pieter
>
> On 08/09/2015 13:03, Stephen Mallette wrote:
> > No need to create an issue - that's a bug in the test. Do you want to
> > submit a PR to fix the tests? if so, you can submit against the tp30
> > branch. If not, just let me know and I can make the corrections
> directly.
> >
> > Thanks,
> >
> > Stephen
> >
> > On Tue, Sep 8, 2015 at 1:46 AM, pieter <pi...@gmail.com> wrote:
> >
> >> Yes it passes then.
> >>
> >> I'll log an issues later.
> >>
> >> Thanks
> >> PIeter
> >>
> >>
> >> On 06/09/2015 03:13, Matt Frantz wrote:
> >>
> >>> Looks like that's a bug in the test, as it shouldn't be necessary to
> >>> escape
> >>> the script engine bindings. Can you try it after changing `${v1Id}` to
> >>> `v1Id`? That's the way the other tests do it.
> >>>
> >>> On Sat, Sep 5, 2015 at 1:52 PM, pieter <pi...@gmail.com>
> wrote:
> >>>
> >>> Hi,
> >>>> I am executing the GroovyProcessStandardSuite for the first time and
> >>>> there are 2 failing tests.
> >>>>
> >>>>
> >>>>
> >>>>
> GroovyStoreTest.get_g_VX1X_storeXaX_byXnameX_out_storeXaX_byXnameX_name_capXaX
> >>>> GroovyRepeatTest.get_g_VX1X_repeatXoutX_untilXoutE_count_isX0XX_name
> >>>>
> >>>> Both are failing because of the string interpolation,
> >>>>
> >>>> "g.V(${v1Id})....."
> >>>>
> >>>> in sqlg's case ${v1id} returns a string that is invalid groovy,
> >>>>
> >>>> "g.V(PUBLIC.person:::0)...."
> >>>>
> >>>> If it is wrapped in single quotes then all is fine.
> >>>>
> >>>> Shall I just opt out of the test, or should the test be smarter as it
> is
> >>>> assuming a numeric id?
> >>>>
> >>>> Thanks
> >>>> Pieter
> >>>>
> >>>>
>
>
Re: Groovy tests failing
Posted by pieter-gmail <pi...@gmail.com>.
I won't get time to do a PR till the weekend, so might as well do it
directly.
Cheers
Pieter
On 08/09/2015 13:03, Stephen Mallette wrote:
> No need to create an issue - that's a bug in the test. Do you want to
> submit a PR to fix the tests? if so, you can submit against the tp30
> branch. If not, just let me know and I can make the corrections directly.
>
> Thanks,
>
> Stephen
>
> On Tue, Sep 8, 2015 at 1:46 AM, pieter <pi...@gmail.com> wrote:
>
>> Yes it passes then.
>>
>> I'll log an issues later.
>>
>> Thanks
>> PIeter
>>
>>
>> On 06/09/2015 03:13, Matt Frantz wrote:
>>
>>> Looks like that's a bug in the test, as it shouldn't be necessary to
>>> escape
>>> the script engine bindings. Can you try it after changing `${v1Id}` to
>>> `v1Id`? That's the way the other tests do it.
>>>
>>> On Sat, Sep 5, 2015 at 1:52 PM, pieter <pi...@gmail.com> wrote:
>>>
>>> Hi,
>>>> I am executing the GroovyProcessStandardSuite for the first time and
>>>> there are 2 failing tests.
>>>>
>>>>
>>>>
>>>> GroovyStoreTest.get_g_VX1X_storeXaX_byXnameX_out_storeXaX_byXnameX_name_capXaX
>>>> GroovyRepeatTest.get_g_VX1X_repeatXoutX_untilXoutE_count_isX0XX_name
>>>>
>>>> Both are failing because of the string interpolation,
>>>>
>>>> "g.V(${v1Id})....."
>>>>
>>>> in sqlg's case ${v1id} returns a string that is invalid groovy,
>>>>
>>>> "g.V(PUBLIC.person:::0)...."
>>>>
>>>> If it is wrapped in single quotes then all is fine.
>>>>
>>>> Shall I just opt out of the test, or should the test be smarter as it is
>>>> assuming a numeric id?
>>>>
>>>> Thanks
>>>> Pieter
>>>>
>>>>
Re: Groovy tests failing
Posted by Stephen Mallette <sp...@gmail.com>.
No need to create an issue - that's a bug in the test. Do you want to
submit a PR to fix the tests? if so, you can submit against the tp30
branch. If not, just let me know and I can make the corrections directly.
Thanks,
Stephen
On Tue, Sep 8, 2015 at 1:46 AM, pieter <pi...@gmail.com> wrote:
> Yes it passes then.
>
> I'll log an issues later.
>
> Thanks
> PIeter
>
>
> On 06/09/2015 03:13, Matt Frantz wrote:
>
>> Looks like that's a bug in the test, as it shouldn't be necessary to
>> escape
>> the script engine bindings. Can you try it after changing `${v1Id}` to
>> `v1Id`? That's the way the other tests do it.
>>
>> On Sat, Sep 5, 2015 at 1:52 PM, pieter <pi...@gmail.com> wrote:
>>
>> Hi,
>>>
>>> I am executing the GroovyProcessStandardSuite for the first time and
>>> there are 2 failing tests.
>>>
>>>
>>>
>>> GroovyStoreTest.get_g_VX1X_storeXaX_byXnameX_out_storeXaX_byXnameX_name_capXaX
>>> GroovyRepeatTest.get_g_VX1X_repeatXoutX_untilXoutE_count_isX0XX_name
>>>
>>> Both are failing because of the string interpolation,
>>>
>>> "g.V(${v1Id})....."
>>>
>>> in sqlg's case ${v1id} returns a string that is invalid groovy,
>>>
>>> "g.V(PUBLIC.person:::0)...."
>>>
>>> If it is wrapped in single quotes then all is fine.
>>>
>>> Shall I just opt out of the test, or should the test be smarter as it is
>>> assuming a numeric id?
>>>
>>> Thanks
>>> Pieter
>>>
>>>
>
Re: Groovy tests failing
Posted by pieter <pi...@gmail.com>.
Yes it passes then.
I'll log an issues later.
Thanks
PIeter
On 06/09/2015 03:13, Matt Frantz wrote:
> Looks like that's a bug in the test, as it shouldn't be necessary to escape
> the script engine bindings. Can you try it after changing `${v1Id}` to
> `v1Id`? That's the way the other tests do it.
>
> On Sat, Sep 5, 2015 at 1:52 PM, pieter <pi...@gmail.com> wrote:
>
>> Hi,
>>
>> I am executing the GroovyProcessStandardSuite for the first time and
>> there are 2 failing tests.
>>
>>
>> GroovyStoreTest.get_g_VX1X_storeXaX_byXnameX_out_storeXaX_byXnameX_name_capXaX
>> GroovyRepeatTest.get_g_VX1X_repeatXoutX_untilXoutE_count_isX0XX_name
>>
>> Both are failing because of the string interpolation,
>>
>> "g.V(${v1Id})....."
>>
>> in sqlg's case ${v1id} returns a string that is invalid groovy,
>>
>> "g.V(PUBLIC.person:::0)...."
>>
>> If it is wrapped in single quotes then all is fine.
>>
>> Shall I just opt out of the test, or should the test be smarter as it is
>> assuming a numeric id?
>>
>> Thanks
>> Pieter
>>
Re: Groovy tests failing
Posted by Matt Frantz <ma...@gmail.com>.
Looks like that's a bug in the test, as it shouldn't be necessary to escape
the script engine bindings. Can you try it after changing `${v1Id}` to
`v1Id`? That's the way the other tests do it.
On Sat, Sep 5, 2015 at 1:52 PM, pieter <pi...@gmail.com> wrote:
> Hi,
>
> I am executing the GroovyProcessStandardSuite for the first time and
> there are 2 failing tests.
>
>
> GroovyStoreTest.get_g_VX1X_storeXaX_byXnameX_out_storeXaX_byXnameX_name_capXaX
> GroovyRepeatTest.get_g_VX1X_repeatXoutX_untilXoutE_count_isX0XX_name
>
> Both are failing because of the string interpolation,
>
> "g.V(${v1Id})....."
>
> in sqlg's case ${v1id} returns a string that is invalid groovy,
>
> "g.V(PUBLIC.person:::0)...."
>
> If it is wrapped in single quotes then all is fine.
>
> Shall I just opt out of the test, or should the test be smarter as it is
> assuming a numeric id?
>
> Thanks
> Pieter
>