You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Ankur Goyal <as...@indiana.edu> on 2012/01/06 23:41:32 UTC

Review Request: Addressed issues related to the review request: https://reviews.apache.org/r/3358/#review4202

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3418/
-----------------------------------------------------------

Review request for rave and Marlon Pierce.


Summary
-------

Addressed following:-
-> Used data-* custom attributes to handle rating updates
-> Removed hard coded labels

Empty labels are kept on purpose because if they are removed the plus and minus radio buttons disappear.


Diffs
-----

  trunk/rave-portal-resources/src/main/resources/messages.properties 1227786 
  trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1227786 
  trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1227786 
  trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1227786 
  trunk/rave-portal-resources/src/main/webapp/script/rave_store.js 1227786 

Diff: https://reviews.apache.org/r/3418/diff


Testing
-------


Thanks,

Ankur


Re: Review Request: Addressed issues related to the review request: https://reviews.apache.org/r/3358/#review4202

Posted by Marlon Pierce <mp...@cs.indiana.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3418/#review4292
-----------------------------------------------------------

Ship it!


- Marlon


On 2012-01-06 22:41:32, Ankur Goyal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3418/
> -----------------------------------------------------------
> 
> (Updated 2012-01-06 22:41:32)
> 
> 
> Review request for rave and Marlon Pierce.
> 
> 
> Summary
> -------
> 
> Addressed following:-
> -> Used data-* custom attributes to handle rating updates
> -> Removed hard coded labels
> 
> Empty labels are kept on purpose because if they are removed the plus and minus radio buttons disappear.
> 
> 
> Diffs
> -----
> 
>   trunk/rave-portal-resources/src/main/resources/messages.properties 1227786 
>   trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1227786 
>   trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1227786 
>   trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1227786 
>   trunk/rave-portal-resources/src/main/webapp/script/rave_store.js 1227786 
> 
> Diff: https://reviews.apache.org/r/3418/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ankur
> 
>