[GitHub] [rocketmq-client-cpp] lizhanhui commented on a diff in pull request #441: reduce unnecessary tmp copy

[GitBox <gi...@apache.org>]

lizhanhui commented on code in PR #441:
URL: https://github.com/apache/rocketmq-client-cpp/pull/441#discussion_r954422205


##########
src/MQClientAPIImpl.cpp:
##########
@@ -268,7 +268,7 @@ void MQClientAPIImpl::sendHeartbeat(const string& addr,
   string body;
   pHeartbeatData->Encode(body);
   request.SetBody(body.data(), body.length());

Review Comment:
   Line #270 and #271 duplicate. The data is copied twice.



##########
src/MQClientAPIImpl.cpp:
##########
@@ -888,7 +888,7 @@ void MQClientAPIImpl::lockBatchMQ(const string& addr,
   string body;
   requestBody->Encode(body);
   request.SetBody(body.data(), body.length());

Review Comment:
   Same here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org