[GitHub] [spark] HyukjinKwon commented on a change in pull request #24947: [SPARK-28143][SQL]IN expression missing attribute should throw analysis exception

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #24947: [SPARK-28143][SQL]IN expression missing attribute should throw analysis exception
URL: https://github.com/apache/spark/pull/24947#discussion_r296583009
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
 ##########
 @@ -581,7 +581,6 @@ object FunctionRegistry {
         val params = Seq.fill(expressions.size)(classOf[Expression])
         val f = constructors.find(_.getParameterTypes.toSeq == params).getOrElse {
           val validParametersCount = constructors
-            .filter(_.getParameterTypes.forall(_ == classOf[Expression]))
 
 Review comment:
   This partially reverts #21226. Previous logic was to detect SQL related expressions only but now it includes all constructors that are not related to SQL expressions. Can you elaborate why we revert?
   
   Looks we should rather specially handle `In`'s constructors or handle when `validParametersCount` is empty.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org