You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/12/26 01:36:27 UTC

[GitHub] [apisix] spacewander opened a new issue, #8569: feat: As a user, I want to refactor the resources under apisix.admin, so that we don't need to repeat

spacewander opened a new issue, #8569:
URL: https://github.com/apache/apisix/issues/8569

   ### Description
   
   Currently, all the resources under `apisix.admin` are basically copied and pasted from a template and changed. If you make general changes to the resource, such as fix count or add adapter, you need to change it file by file. And due to historical problems, some resource implementation methods are incomplete.
   I hope we can refactor the code to something like `core.config.new`, where we only need to pass a few parameters to create a new resource.
   
   Note: Please read every resource file before jumping into the refactor. Some resources have particular logic. We need a smart way to handle them.
   
   CC @An-DJ 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] An-DJ commented on issue #8569: feat: As a user, I want to refactor the resources under apisix.admin, so that we don't need to repeat

Posted by "An-DJ (via GitHub)" <gi...@apache.org>.
An-DJ commented on issue #8569:
URL: https://github.com/apache/apisix/issues/8569#issuecomment-1432691141

   The `plugins` is structurally different from other resources. 
   
   Maybe it is NOT need to be refactored. @spacewander Can we remove it from the list?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] An-DJ commented on issue #8569: feat: As a user, I want to refactor the resources under apisix.admin, so that we don't need to repeat

Posted by GitBox <gi...@apache.org>.
An-DJ commented on issue #8569:
URL: https://github.com/apache/apisix/issues/8569#issuecomment-1373018001

   I think we can refactor the resources one by one:
   
   - [ ] routes #8611 
   - [ ] services
   - [ ] upstreams
   - [ ] consumers
   - [ ] ssls
   - [ ] plugins
   - [ ] protos
   - [ ] global_rules
   - [ ] stream_routes
   - [ ] plugin_metadata
   - [ ] plugin_configs
   - [ ] consumer_groups
   - [ ] secrets


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #8569: feat: As a user, I want to refactor the resources under apisix.admin, so that we don't need to repeat

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #8569:
URL: https://github.com/apache/apisix/issues/8569#issuecomment-1373024899

   We can use fewer PRs to implement it. The refactor progress can be faster after several PRs as we will have a stable foundation.
   
   What about refactoring 2~3 resources in the upcoming PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander closed issue #8569: feat: As a user, I want to refactor the resources under apisix.admin, so that we don't need to repeat

Posted by GitBox <gi...@apache.org>.
spacewander closed issue #8569: feat: As a user, I want to refactor the resources under apisix.admin, so that we don't need to repeat
URL: https://github.com/apache/apisix/issues/8569


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org