You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2023/01/06 15:58:35 UTC
[tomcat] 03/03: Additional false positives when running via Ant
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 6a54b9ec542ea261bdc7dfdd85045a81905bd50c
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Fri Jan 6 15:52:28 2023 +0000
Additional false positives when running via Ant
---
res/spotbugs/filter-false-positives.xml | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/res/spotbugs/filter-false-positives.xml b/res/spotbugs/filter-false-positives.xml
index 9a1745c663..ac7915b632 100644
--- a/res/spotbugs/filter-false-positives.xml
+++ b/res/spotbugs/filter-false-positives.xml
@@ -924,6 +924,16 @@
<Method name="emitHeader" />
<Bug pattern="VO_VOLATILE_INCREMENT" />
</Match>
+ <Match>
+ <!-- False positive. Affects 4.7.3. May affect other versions. -->
+ <Class name="org.apache.coyote.http2.HpackDecoder" />
+ <Method name="handleMaxMemorySizeChange" />
+ <Or>
+ <Field name="currentMemorySize" />
+ <Field name="filledTableSlots" />
+ </Or>
+ <Bug pattern="SA_FIELD_SELF_ASSIGNMENT" />
+ </Match>
<Match>
<!-- Number being tested is unsigned. -->
<Class name="org.apache.coyote.http2.Http2UpgradeHandler" />
@@ -945,6 +955,12 @@
<Bug pattern="NO_NOTIFY_NOT_NOTIFYALL" />
</Or>
</Match>
+ <Match>
+ <!-- Switch fall-through is intentional. -->
+ <Class name="org.apache.coyote.http2.Http2UpgradeHandler" />
+ <Method name="upgradeDispatch" />
+ <Bug pattern="SF_SWITCH_FALLTHROUGH" />
+ </Match>
<Match>
<!-- Return value is intentionally ignored. -->
<Class name="org.apache.coyote.http2.Http2UpgradeHandler$PingManager" />
@@ -1210,12 +1226,20 @@
<!-- SQL construction is necessary for pooled statements -->
<Class name="org.apache.tomcat.dbcp.dbcp2.PStmtKey" />
<Or>
+ <!-- Names reported via IDE -->
<Method name="lambda$3" />
<Method name="lambda$4" />
<Method name="lambda$5" />
<Method name="lambda$6" />
<Method name="lambda$7" />
<Method name="lambda$8" />
+ <!-- Names reported via Ant -->
+ <Method name="lambda$static$3" />
+ <Method name="lambda$static$4" />
+ <Method name="lambda$static$5" />
+ <Method name="lambda$static$6" />
+ <Method name="lambda$static$7" />
+ <Method name="lambda$static$8" />
</Or>
<Bug pattern="SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING" />
</Match>
@@ -1397,6 +1421,12 @@
<Method name="toString"/>
<Bug code="NP" />
</Match>
+ <Match>
+ <!-- Switch fall-through is intentional. -->
+ <Class name="org.apache.tomcat.util.buf.MessageBytes"/>
+ <Method name="toChars"/>
+ <Bug pattern="SF_SWITCH_FALLTHROUGH" />
+ </Match>
<Match>
<!-- Returning null here is fine -->
<Class name="org.apache.tomcat.util.buf.MessageBytes"/>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org