You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/08/23 10:54:51 UTC
[GitHub] [lucene] mikemccand commented on a change in pull request #255: LUCENE-5309: Optimize facet counting for single-valued SSDV / StringValueFacetCounts
mikemccand commented on a change in pull request #255:
URL: https://github.com/apache/lucene/pull/255#discussion_r693867020
##########
File path: lucene/facet/src/java/org/apache/lucene/facet/sortedset/ConcurrentSortedSetDocValuesFacetCounts.java
##########
@@ -286,7 +310,7 @@ private final void count(List<MatchingDocs> matchingDocs)
}
/** Does all the "real work" of tallying up the counts. */
- private final void countAll() throws IOException, InterruptedException {
Review comment:
More `final` attrition.
##########
File path: lucene/core/src/java/org/apache/lucene/index/MultiDocValues.java
##########
@@ -680,9 +673,9 @@ public static SortedSetDocValues getSortedSetValues(final IndexReader r, final S
*/
public static class MultiSortedDocValues extends SortedDocValues {
/** docbase for each leaf: parallel with {@link #values} */
- public final int docStarts[];
+ public final int[] docStarts;
Review comment:
I love it.
##########
File path: lucene/facet/src/java/org/apache/lucene/facet/sortedset/ConcurrentSortedSetDocValuesFacetCounts.java
##########
@@ -103,7 +105,7 @@ public FacetResult getTopChildren(int topN, String dim, String... path) throws I
return getDim(dim, ordRange, topN);
}
- private final FacetResult getDim(String dim, OrdRange ordRange, int topN) throws IOException {
+ private FacetResult getDim(String dim, OrdRange ordRange, int topN) throws IOException {
Review comment:
Hmm why did we remove this `final`? I wonder if the whole class should be `final`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org