You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2021/05/28 15:35:43 UTC

[james-mime4j] 03/07: [WARNING] Remove uneeded redundant interface qualifiers

This is an automated email from the ASF dual-hosted git repository.

btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-mime4j.git

commit f9d84f626623c956029594ae4ea04c6078ca2cfe
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Thu May 27 14:43:26 2021 +0700

    [WARNING] Remove uneeded redundant interface qualifiers
    
    Idem, this was reported by intelliJ inspections.
---
 .../main/java/org/apache/james/mime4j/dom/Multipart.java   |  2 +-
 .../james/mime4j/dom/field/ContentDispositionField.java    | 14 +++++++-------
 .../apache/james/mime4j/dom/field/ContentTypeField.java    | 12 ++++++------
 .../apache/james/mime4j/mboxiterator/FromLinePatterns.java |  4 ++--
 4 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/dom/src/main/java/org/apache/james/mime4j/dom/Multipart.java b/dom/src/main/java/org/apache/james/mime4j/dom/Multipart.java
index 98d9399..1685cd5 100644
--- a/dom/src/main/java/org/apache/james/mime4j/dom/Multipart.java
+++ b/dom/src/main/java/org/apache/james/mime4j/dom/Multipart.java
@@ -52,7 +52,7 @@ public interface Multipart extends Body {
      *
      * @return the list of <code>Entity</code> objects.
      */
-    public List<Entity> getBodyParts();
+    List<Entity> getBodyParts();
 
     /**
      * Sets the list of body parts.
diff --git a/dom/src/main/java/org/apache/james/mime4j/dom/field/ContentDispositionField.java b/dom/src/main/java/org/apache/james/mime4j/dom/field/ContentDispositionField.java
index 7e2961e..3a0699c 100644
--- a/dom/src/main/java/org/apache/james/mime4j/dom/field/ContentDispositionField.java
+++ b/dom/src/main/java/org/apache/james/mime4j/dom/field/ContentDispositionField.java
@@ -25,19 +25,19 @@ import java.util.Map;
 public interface ContentDispositionField extends ParsedField {
 
     /** The <code>inline</code> disposition type. */
-    public static final String DISPOSITION_TYPE_INLINE = "inline";
+    String DISPOSITION_TYPE_INLINE = "inline";
     /** The <code>attachment</code> disposition type. */
-    public static final String DISPOSITION_TYPE_ATTACHMENT = "attachment";
+    String DISPOSITION_TYPE_ATTACHMENT = "attachment";
     /** The name of the <code>filename</code> parameter. */
-    public static final String PARAM_FILENAME = "filename";
+    String PARAM_FILENAME = "filename";
     /** The name of the <code>creation-date</code> parameter. */
-    public static final String PARAM_CREATION_DATE = "creation-date";
+    String PARAM_CREATION_DATE = "creation-date";
     /** The name of the <code>modification-date</code> parameter. */
-    public static final String PARAM_MODIFICATION_DATE = "modification-date";
+    String PARAM_MODIFICATION_DATE = "modification-date";
     /** The name of the <code>read-date</code> parameter. */
-    public static final String PARAM_READ_DATE = "read-date";
+    String PARAM_READ_DATE = "read-date";
     /** The name of the <code>size</code> parameter. */
-    public static final String PARAM_SIZE = "size";
+    String PARAM_SIZE = "size";
 
     /**
      * Gets the disposition type defined in this Content-Disposition field.
diff --git a/dom/src/main/java/org/apache/james/mime4j/dom/field/ContentTypeField.java b/dom/src/main/java/org/apache/james/mime4j/dom/field/ContentTypeField.java
index 1885060..2a5670f 100644
--- a/dom/src/main/java/org/apache/james/mime4j/dom/field/ContentTypeField.java
+++ b/dom/src/main/java/org/apache/james/mime4j/dom/field/ContentTypeField.java
@@ -24,17 +24,17 @@ import java.util.Map;
 public interface ContentTypeField extends ParsedField {
 
     /** The prefix of all <code>multipart</code> MIME types. */
-    public static final String TYPE_MULTIPART_PREFIX = "multipart/";
+    String TYPE_MULTIPART_PREFIX = "multipart/";
     /** The <code>multipart/digest</code> MIME type. */
-    public static final String TYPE_MULTIPART_DIGEST = "multipart/digest";
+    String TYPE_MULTIPART_DIGEST = "multipart/digest";
     /** The <code>text/plain</code> MIME type. */
-    public static final String TYPE_TEXT_PLAIN = "text/plain";
+    String TYPE_TEXT_PLAIN = "text/plain";
     /** The <code>message/rfc822</code> MIME type. */
-    public static final String TYPE_MESSAGE_RFC822 = "message/rfc822";
+    String TYPE_MESSAGE_RFC822 = "message/rfc822";
     /** The name of the <code>boundary</code> parameter. */
-    public static final String PARAM_BOUNDARY = "boundary";
+    String PARAM_BOUNDARY = "boundary";
     /** The name of the <code>charset</code> parameter. */
-    public static final String PARAM_CHARSET = "charset";
+    String PARAM_CHARSET = "charset";
 
     /**
      * Gets the MIME type defined in this Content-Type field.
diff --git a/mbox/src/main/java/org/apache/james/mime4j/mboxiterator/FromLinePatterns.java b/mbox/src/main/java/org/apache/james/mime4j/mboxiterator/FromLinePatterns.java
index 3087472..73486f7 100644
--- a/mbox/src/main/java/org/apache/james/mime4j/mboxiterator/FromLinePatterns.java
+++ b/mbox/src/main/java/org/apache/james/mime4j/mboxiterator/FromLinePatterns.java
@@ -28,13 +28,13 @@ public interface FromLinePatterns {
     /**
      * Match a line like: From ieugen@apache.org Fri Sep 09 14:04:52 2011
      */
-    static final String DEFAULT = "^From \\S+@\\S.*\\d{4}$";
+    String DEFAULT = "^From \\S+@\\S.*\\d{4}$";
     /**
      * Matches other type of From_ line (without @):
      * From MAILER-DAEMON Wed Oct 05 21:54:09 2011
      * Thunderbird mbox content: From - Wed Apr 02 06:51:08 2014
      */
-    static final String DEFAULT2 = "^From \\S+.*\\d{4}$";
+    String DEFAULT2 = "^From \\S+.*\\d{4}$";
 
 
 }

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org