You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Henri Yandell <fl...@gmail.com> on 2007/08/15 17:44:42 UTC
Fwd: [CLI] Getting moving with 2.0
(DNS issues, trying again)
---------- Forwarded message ----------
From: Henri Yandell <fl...@gmail.com>
Date: Aug 15, 2007 6:56 AM
Subject: [CLI] Getting moving with 2.0
To: Jakarta Commons Developers List <de...@commons.apache.org>, Andrew
Shirley <ak...@decisionsoft.co.uk>
Two different angles I guess.
Firstly we've got 17 issues open, and secondly we have opinions on
directions to take the library. It's easiest to get started on the
issues I think, so here are the ones that look like our obvious
targets:
* https://issues.apache.org/jira/browse/CLI-61
Andrew Shirley reported this and supplied a patch. Need someone to
look at this and then we can apply it (Andrew, are you still around?).
* https://issues.apache.org/jira/browse/CLI-6
This has a patch from Brian Hanson. Looks like Rob thought there were
decisions to make, so this is a good one to get started on thinking of
the big picture with. Anyone have any views on this one?
* https://issues.apache.org/jira/browse/CLI-122
A note from me that we need a test for CLI-51 in CLI 2.0. Brian added
a unit test to CLI1 to fix CLI-51, any thoughts on doing the same for
CLI 2.0 Brian?
* https://issues.apache.org/jira/browse/CLI-118
Spanish bundle for CLI. I suspect this would be quite educational to
dig into - we need to make sure that we also clean up the .properties
as in my experience they tend to accumulate unused properties.
* https://issues.apache.org/jira/browse/CLI-99
Can someone confirm that this is not an issue in CLI2?
Hen
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [CLI] Getting moving with 2.0
Posted by sebb <se...@gmail.com>.
On 15/08/07, Henri Yandell <fl...@gmail.com> wrote:
> For the latter, I use:
>
> function propcheck() {
> for i in `find $1 -type f -name '*.properties'`
> do
> for j in `cat $i | sed 's/=.*//'`
This does not allow for comment or continuation lines ...
> do
> grep -R --exclude='*properties*' --exclude='*svn*' $j $1 > /dev/null
Might be safer to include only *.java files. Can properties be used
in other files?
Otherwise certainly need to exclude *.metaprop files (used by at least
one I18n editor).
Would also be safer to match "$j", as the property name has to be
quoted when used. Otherwise it can match property names that are a
substring of other names.
It can still match property names that are not being used as properties.
This may or may not be a big problem, depending on the naming
convention (if any) used, and particularly the length of the property
names - shorter ones are more likely to trigger false matches.
> if [ $? -ne 0 ]
> then
> echo "Property $j is missing."
> else
> echo "Property $j is good."
> fi
> done
> done
> }
> On 8/15/07, sebb <se...@gmail.com> wrote:
> > On 15/08/07, Henri Yandell <fl...@gmail.com> wrote:
> > > (DNS issues, trying again)
> > >
> > > ---------- Forwarded message ----------
> > > From: Henri Yandell <fl...@gmail.com>
> > > Date: Aug 15, 2007 6:56 AM
> > > Subject: [CLI] Getting moving with 2.0
> > > To: Jakarta Commons Developers List <de...@commons.apache.org>, Andrew
> > > Shirley <ak...@decisionsoft.co.uk>
> > >
> > >
> > > Two different angles I guess.
> > >
> > > Firstly we've got 17 issues open, and secondly we have opinions on
> > > directions to take the library. It's easiest to get started on the
> > > issues I think, so here are the ones that look like our obvious
> > > targets:
> > >
> > > * https://issues.apache.org/jira/browse/CLI-61
> > >
> > > Andrew Shirley reported this and supplied a patch. Need someone to
> > > look at this and then we can apply it (Andrew, are you still around?).
> > >
> > > * https://issues.apache.org/jira/browse/CLI-6
> > >
> > > This has a patch from Brian Hanson. Looks like Rob thought there were
> > > decisions to make, so this is a good one to get started on thinking of
> > > the big picture with. Anyone have any views on this one?
> > >
> > > * https://issues.apache.org/jira/browse/CLI-122
> > >
> > > A note from me that we need a test for CLI-51 in CLI 2.0. Brian added
> > > a unit test to CLI1 to fix CLI-51, any thoughts on doing the same for
> > > CLI 2.0 Brian?
> > >
> > > * https://issues.apache.org/jira/browse/CLI-118
> > >
> > > Spanish bundle for CLI. I suspect this would be quite educational to
> > > dig into - we need to make sure that we also clean up the .properties
> > > as in my experience they tend to accumulate unused properties.
> >
> > JMeter has some test code to check that there aren't any extra
> > properties in "foreign" bundles compared with the "native" bundle. I
> > could dig that out if required. Checking for spurious entries in the
> > "native" bundle is rather harder ...
> >
> > > * https://issues.apache.org/jira/browse/CLI-99
> > >
> > > Can someone confirm that this is not an issue in CLI2?
> > >
> > >
> > > Hen
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > > For additional commands, e-mail: dev-help@commons.apache.org
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [CLI] Getting moving with 2.0
Posted by Henri Yandell <fl...@gmail.com>.
For the latter, I use:
function propcheck() {
for i in `find $1 -type f -name '*.properties'`
do
for j in `cat $i | sed 's/=.*//'`
do
grep -R --exclude='*properties*' --exclude='*svn*' $j $1 > /dev/null
if [ $? -ne 0 ]
then
echo "Property $j is missing."
else
echo "Property $j is good."
fi
done
done
}
On 8/15/07, sebb <se...@gmail.com> wrote:
> On 15/08/07, Henri Yandell <fl...@gmail.com> wrote:
> > (DNS issues, trying again)
> >
> > ---------- Forwarded message ----------
> > From: Henri Yandell <fl...@gmail.com>
> > Date: Aug 15, 2007 6:56 AM
> > Subject: [CLI] Getting moving with 2.0
> > To: Jakarta Commons Developers List <de...@commons.apache.org>, Andrew
> > Shirley <ak...@decisionsoft.co.uk>
> >
> >
> > Two different angles I guess.
> >
> > Firstly we've got 17 issues open, and secondly we have opinions on
> > directions to take the library. It's easiest to get started on the
> > issues I think, so here are the ones that look like our obvious
> > targets:
> >
> > * https://issues.apache.org/jira/browse/CLI-61
> >
> > Andrew Shirley reported this and supplied a patch. Need someone to
> > look at this and then we can apply it (Andrew, are you still around?).
> >
> > * https://issues.apache.org/jira/browse/CLI-6
> >
> > This has a patch from Brian Hanson. Looks like Rob thought there were
> > decisions to make, so this is a good one to get started on thinking of
> > the big picture with. Anyone have any views on this one?
> >
> > * https://issues.apache.org/jira/browse/CLI-122
> >
> > A note from me that we need a test for CLI-51 in CLI 2.0. Brian added
> > a unit test to CLI1 to fix CLI-51, any thoughts on doing the same for
> > CLI 2.0 Brian?
> >
> > * https://issues.apache.org/jira/browse/CLI-118
> >
> > Spanish bundle for CLI. I suspect this would be quite educational to
> > dig into - we need to make sure that we also clean up the .properties
> > as in my experience they tend to accumulate unused properties.
>
> JMeter has some test code to check that there aren't any extra
> properties in "foreign" bundles compared with the "native" bundle. I
> could dig that out if required. Checking for spurious entries in the
> "native" bundle is rather harder ...
>
> > * https://issues.apache.org/jira/browse/CLI-99
> >
> > Can someone confirm that this is not an issue in CLI2?
> >
> >
> > Hen
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [CLI] Getting moving with 2.0
Posted by sebb <se...@gmail.com>.
On 15/08/07, Henri Yandell <fl...@gmail.com> wrote:
> (DNS issues, trying again)
>
> ---------- Forwarded message ----------
> From: Henri Yandell <fl...@gmail.com>
> Date: Aug 15, 2007 6:56 AM
> Subject: [CLI] Getting moving with 2.0
> To: Jakarta Commons Developers List <de...@commons.apache.org>, Andrew
> Shirley <ak...@decisionsoft.co.uk>
>
>
> Two different angles I guess.
>
> Firstly we've got 17 issues open, and secondly we have opinions on
> directions to take the library. It's easiest to get started on the
> issues I think, so here are the ones that look like our obvious
> targets:
>
> * https://issues.apache.org/jira/browse/CLI-61
>
> Andrew Shirley reported this and supplied a patch. Need someone to
> look at this and then we can apply it (Andrew, are you still around?).
>
> * https://issues.apache.org/jira/browse/CLI-6
>
> This has a patch from Brian Hanson. Looks like Rob thought there were
> decisions to make, so this is a good one to get started on thinking of
> the big picture with. Anyone have any views on this one?
>
> * https://issues.apache.org/jira/browse/CLI-122
>
> A note from me that we need a test for CLI-51 in CLI 2.0. Brian added
> a unit test to CLI1 to fix CLI-51, any thoughts on doing the same for
> CLI 2.0 Brian?
>
> * https://issues.apache.org/jira/browse/CLI-118
>
> Spanish bundle for CLI. I suspect this would be quite educational to
> dig into - we need to make sure that we also clean up the .properties
> as in my experience they tend to accumulate unused properties.
JMeter has some test code to check that there aren't any extra
properties in "foreign" bundles compared with the "native" bundle. I
could dig that out if required. Checking for spurious entries in the
"native" bundle is rather harder ...
> * https://issues.apache.org/jira/browse/CLI-99
>
> Can someone confirm that this is not an issue in CLI2?
>
>
> Hen
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: Fwd: [CLI] Getting moving with 2.0
Posted by Wolfgang Roessler <co...@roessler-wolfgang.de>.
Hi,
I have been thinking about CLI a bit the last few days and here are my
ideas:
- Building the command-line with the builders works good, although
creating all the different builders is a bit uncomfortable
- I think the parsing and validation-step should be separated. We would
need more Option/Argument types, e.g. FileArgument for this. In a first
step the command-line arguments shoudl be assigned to the option it most
likely belongs. In the second step, the validation should be done.
Currently this is mixed up, so a write-protected file will never be
consider for a file-argument. This results in error-messages which are
hard to interpret.
- The exact meaning of a Group should be described somewhere, I am still
wondering what exactly it represents and what not.
- There should be a possibility to model dependencies between
options/arguments (mutually exclusive for example)
Perhaps we should collect a list of different command-line examples we
wish to "support" ,e.g. like in the posting "[CLI] HelpFormatter
Question". Some kind of requirements-collection.
Regards,
Wolfgang Roessler
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org