[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #7086: WIP: Enable color consistency in a dashboard (Need to add unit tests)

[GitBox <gi...@apache.org>]

graceguo-supercat commented on a change in pull request #7086: WIP: Enable color consistency in a dashboard (Need to add unit tests)
URL: https://github.com/apache/incubator-superset/pull/7086#discussion_r268002226
 
 

 ##########
 File path: superset/assets/src/dashboard/reducers/getInitialState.js
 ##########
 @@ -149,6 +157,17 @@ export default function(bootstrapData) {
     },
   };
 
+  // store the color scheme as a layout component so we can undo/redo changes
+  layout[COLOR_SCHEME_ID] = {
 
 Review comment:
   could you not use `layout`? `layout` stores actual layout in a flattened tree structure. we can traverse the `layout` attribute to build the whole tree. color_scheme should not ride on this specific data structure.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org