You are viewing a plain text version of this content. The canonical link for it is here.
Posted to xap-commits@incubator.apache.org by mt...@apache.org on 2007/03/19 17:30:12 UTC
svn commit: r520018 - in /incubator/xap/trunk/codebase/src/xap:
bridges/dojo/TableBridge.js widgets/dojo/TreeTable.js
Author: mturyn
Date: Mon Mar 19 10:30:11 2007
New Revision: 520018
URL: http://svn.apache.org/viewvc?view=rev&rev=520018
Log:
Real (?) fix for Xap-315 (initially-hidden tables not right).
The problem was with TreeTable._rebuildHead: it was insensitive to the actual header visibility as set, finding it and then doing nothing with it.
Modified:
incubator/xap/trunk/codebase/src/xap/bridges/dojo/TableBridge.js
incubator/xap/trunk/codebase/src/xap/widgets/dojo/TreeTable.js
Modified: incubator/xap/trunk/codebase/src/xap/bridges/dojo/TableBridge.js
URL: http://svn.apache.org/viewvc/incubator/xap/trunk/codebase/src/xap/bridges/dojo/TableBridge.js?view=diff&rev=520018&r1=520017&r2=520018
==============================================================================
--- incubator/xap/trunk/codebase/src/xap/bridges/dojo/TableBridge.js (original)
+++ incubator/xap/trunk/codebase/src/xap/bridges/dojo/TableBridge.js Mon Mar 19 10:30:11 2007
@@ -146,38 +146,3 @@
this.getPeer().removeRow(childPeer);
}
}
-
-xap.bridges.dojo.TableBridge.hidingDisplacement = 10000 ;
-
-//IMPORTANT REVISIT THIS
-xap.bridges.dojo.TableBridge.prototype.setVisibleAttribute = function(pszTf){
-// Problems laying out the table correctly if it's invisible at the
-// start, so it's better to make "hide"=="move offscreen"
- var bVis = (pszTf=="false")?false:true ;
-
- // hide
- if(!bVis ){
- var y = this.getElement().getAttribute("y") ;
- if(y){
- this.setYAttribute(y) ;
- }
- y = this.getRootDomNode().offsetTop ;
- // Don't move offscreen if we've already been moved offscreen:
- if( !this._wasDisplacedOffscreen){
- y -= xap.bridges.dojo.TableBridge.hidingDisplacement ;
- }
- this.setYAttribute(y +"px") ;
- this._wasDisplacedOffscreen = true ;
- } else {
- // We're showing a table which was hidden, and
- // so moved offscreen---move it back:
- y = this.getRootDomNode().offsetTop ;
- // Don't move back onscreen unless we've started offscreen:
- if( this._wasDisplacedOffscreen){
- y += xap.bridges.dojo.TableBridge.hidingDisplacement ;
- }
- this.setYAttribute(y+"px") ;
- this._wasDisplacedOffscreen = false ;
- //this.getPeer()._resizeTable() ;
- }
-}
\ No newline at end of file
Modified: incubator/xap/trunk/codebase/src/xap/widgets/dojo/TreeTable.js
URL: http://svn.apache.org/viewvc/incubator/xap/trunk/codebase/src/xap/widgets/dojo/TreeTable.js?view=diff&rev=520018&r1=520017&r2=520018
==============================================================================
--- incubator/xap/trunk/codebase/src/xap/widgets/dojo/TreeTable.js (original)
+++ incubator/xap/trunk/codebase/src/xap/widgets/dojo/TreeTable.js Mon Mar 19 10:30:11 2007
@@ -282,7 +282,7 @@
*/
_rebuildHead: function(){
- var headerVisibility = this.headerDiv.style.visibility;
+ this._headerVisibility = this.headerDiv.style.visibility;
this.domNode.removeChild(this.headerDiv);
this.headerDiv = document.createElement("div");