You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2016/01/05 05:47:44 UTC

Review Request 41906: Fixed docker containerizer usage to check for cgroup result.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41906/
-----------------------------------------------------------

Review request for mesos, Jie Yu and Jojy Varghese.


Bugs: MESOS-4031
    https://issues.apache.org/jira/browse/MESOS-4031


Repository: mesos


Description
-------

Fixed docker containerizer usage to check for cgroup result.


Diffs
-----

  src/slave/containerizer/docker.cpp aacf90f2cb6c08f94340936d29b2df513ac9825a 

Diff: https://reviews.apache.org/r/41906/diff/


Testing
-------

make check


Thanks,

Timothy Chen


Re: Review Request 41906: Fixed docker containerizer usage to check for cgroup result.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41906/#review112813
-----------------------------------------------------------


Patch looks great!

Reviews applied: [41906]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 5, 2016, 4:47 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41906/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 4:47 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Jojy Varghese.
> 
> 
> Bugs: MESOS-4031
>     https://issues.apache.org/jira/browse/MESOS-4031
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed docker containerizer usage to check for cgroup result.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp aacf90f2cb6c08f94340936d29b2df513ac9825a 
> 
> Diff: https://reviews.apache.org/r/41906/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Re: Review Request 41906: Fixed docker containerizer usage to check for cgroup result.

Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41906/#review112977
-----------------------------------------------------------

Ship it!


Ship It!

- Jojy Varghese


On Jan. 5, 2016, 4:47 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41906/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 4:47 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Jojy Varghese.
> 
> 
> Bugs: MESOS-4031
>     https://issues.apache.org/jira/browse/MESOS-4031
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed docker containerizer usage to check for cgroup result.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp aacf90f2cb6c08f94340936d29b2df513ac9825a 
> 
> Diff: https://reviews.apache.org/r/41906/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>