You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org> on 2011/09/23 22:19:28 UTC

[jira] [Created] (TAP5-1664) @InjectResource annotation should be removed, behavior of @Inject on a field should be changed to consider resources first

@InjectResource annotation should be removed, behavior of @Inject on a field should be changed to consider resources first
--------------------------------------------------------------------------------------------------------------------------

                 Key: TAP5-1664
                 URL: https://issues.apache.org/jira/browse/TAP5-1664
             Project: Tapestry 5
          Issue Type: Bug
          Components: tapestry-ioc
    Affects Versions: 5.3, 5.2
            Reporter: Howard M. Lewis Ship


The @InjectResource annotation is confusing and, ultimately, unnecessary. For the rare case where there's a service of type Messages or such, you can always change your constructor to take an ObjectLocator and look up the Messages service that way.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (TAP5-1664) @InjectResource annotation should be removed, behavior of @Inject on a field should be changed to consider resources first

Posted by "Howard M. Lewis Ship (Closed) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-1664.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 5.3
         Assignee: Howard M. Lewis Ship

Deprecated and marked for removal
                
> @InjectResource annotation should be removed, behavior of @Inject on a field should be changed to consider resources first
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1664
>                 URL: https://issues.apache.org/jira/browse/TAP5-1664
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-ioc
>    Affects Versions: 5.3, 5.2
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.3
>
>
> The @InjectResource annotation is confusing and, ultimately, unnecessary. For the rare case where there's a service of type Messages or such, you can always change your constructor to take an ObjectLocator and look up the Messages service that way.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (TAP5-1664) @InjectResource annotation should be removed, behavior of @Inject on a field should be changed to consider resources first

Posted by "Howard M. Lewis Ship (Closed) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-1664.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 5.3
         Assignee: Howard M. Lewis Ship

Deprecated and marked for removal
                
> @InjectResource annotation should be removed, behavior of @Inject on a field should be changed to consider resources first
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1664
>                 URL: https://issues.apache.org/jira/browse/TAP5-1664
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-ioc
>    Affects Versions: 5.3, 5.2
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.3
>
>
> The @InjectResource annotation is confusing and, ultimately, unnecessary. For the rare case where there's a service of type Messages or such, you can always change your constructor to take an ObjectLocator and look up the Messages service that way.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1664) @InjectResource annotation should be removed, behavior of @Inject on a field should be changed to consider resources first

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113898#comment-13113898 ] 

Hudson commented on TAP5-1664:
------------------------------

Integrated in tapestry-trunk-freestyle #539 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/539/])
    TAP5-1664: @InjectResource annotation should be removed, behavior of @Inject on a field should be changed to consider resources first

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1175102
Files : 
* /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/util/InternalUtils.java
* /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/util/UtilMessages.java
* /tapestry/tapestry5/trunk/tapestry-ioc/src/main/resources/org/apache/tapestry5/ioc/internal/util/UtilStrings.properties
* /tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/FailedFieldInjectionStringTransformer.java
* /tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/FieldResourceInjectionModule.java
* /tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/IntegrationTest.java
* /tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/InternalUtilsTest.java
* /tapestry/tapestry5/trunk/tapestry5-annotations/src/main/java/org/apache/tapestry5/ioc/annotations/InjectResource.java


> @InjectResource annotation should be removed, behavior of @Inject on a field should be changed to consider resources first
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1664
>                 URL: https://issues.apache.org/jira/browse/TAP5-1664
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-ioc
>    Affects Versions: 5.3, 5.2
>            Reporter: Howard M. Lewis Ship
>
> The @InjectResource annotation is confusing and, ultimately, unnecessary. For the rare case where there's a service of type Messages or such, you can always change your constructor to take an ObjectLocator and look up the Messages service that way.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1664) @InjectResource annotation should be removed, behavior of @Inject on a field should be changed to consider resources first

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113898#comment-13113898 ] 

Hudson commented on TAP5-1664:
------------------------------

Integrated in tapestry-trunk-freestyle #539 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/539/])
    TAP5-1664: @InjectResource annotation should be removed, behavior of @Inject on a field should be changed to consider resources first

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1175102
Files : 
* /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/util/InternalUtils.java
* /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/util/UtilMessages.java
* /tapestry/tapestry5/trunk/tapestry-ioc/src/main/resources/org/apache/tapestry5/ioc/internal/util/UtilStrings.properties
* /tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/FailedFieldInjectionStringTransformer.java
* /tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/FieldResourceInjectionModule.java
* /tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/IntegrationTest.java
* /tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/util/InternalUtilsTest.java
* /tapestry/tapestry5/trunk/tapestry5-annotations/src/main/java/org/apache/tapestry5/ioc/annotations/InjectResource.java


> @InjectResource annotation should be removed, behavior of @Inject on a field should be changed to consider resources first
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1664
>                 URL: https://issues.apache.org/jira/browse/TAP5-1664
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-ioc
>    Affects Versions: 5.3, 5.2
>            Reporter: Howard M. Lewis Ship
>
> The @InjectResource annotation is confusing and, ultimately, unnecessary. For the rare case where there's a service of type Messages or such, you can always change your constructor to take an ObjectLocator and look up the Messages service that way.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira