[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1603: MINIFICPP-2098 Add ENABLE_ALL for all extensions

["fgerlits (via GitHub)" <gi...@apache.org>]

fgerlits commented on code in PR #1603:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1603#discussion_r1260874176


##########
extensions/kubernetes/CMakeLists.txt:
##########
@@ -14,8 +14,7 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-
-if (NOT (CMAKE_SYSTEM_NAME STREQUAL "Linux" AND ENABLE_KUBERNETES))
+if (NOT (CMAKE_SYSTEM_NAME STREQUAL "Linux" AND (ENABLE_ALL OR ENABLE_KUBERNETES)))

Review Comment:
   You added a `NOT OPENSSL_OFF` condition to this in #1583; please rebase and resolve the conflict.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org