[jira] [Resolved] (SOLR-11877) DocCollection.getStateFormat is buggy; sometimes wrong

["Mike Drob (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Drob resolved SOLR-11877.
------------------------------
    Fix Version/s: master (9.0)
         Assignee: Mike Drob
       Resolution: Fixed

Fixed via SOLR-12823

> DocCollection.getStateFormat is buggy; sometimes wrong
> ------------------------------------------------------
>
>                 Key: SOLR-11877
>                 URL: https://issues.apache.org/jira/browse/SOLR-11877
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>            Reporter: David Smiley
>            Assignee: Mike Drob
>            Priority: Major
>             Fix For: master (9.0)
>
>
> The ability to know what the collection / ClusterState "stateFormat" integer is per collection is a bit buggy.  After looking at the problem for awhile, I think it would help a lot if DocCollection accepted the stateFormat param to thus force the caller to consider it.  Today the caller passes the znode path... but in several places we pass ZkStateReader.CLUSTER_STATE or null (both implying stateFormat==1) which is sometimes not accurate.  Nobody seems to actually need the znode path from the DocCollection but the stateFormat is requested in a bunch of places.
> The particular bug I see is org.apache.solr.client.solrj.impl.HttpClusterStateProvider#fetchClusterState passing ZkStateReader.CLUSTER_STATE when in reality it has no clue what the format is because our cluster_status API doesn't return the stateFormat.
> Maybe getStateFormat should return an Integer object and hence can be null if it's not known.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org