You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org> on 2012/06/04 18:53:23 UTC

[jira] [Created] (MYFACES-3561) [perf] skip UniqueIdVendor.createUniqueId(FacesContext context, String seed) for facelets generated component ids

Leonardo Uribe created MYFACES-3561:
---------------------------------------

             Summary: [perf] skip UniqueIdVendor.createUniqueId(FacesContext context, String seed) for facelets generated component ids
                 Key: MYFACES-3561
                 URL: https://issues.apache.org/jira/browse/MYFACES-3561
             Project: MyFaces Core
          Issue Type: Improvement
          Components: JSR-314
            Reporter: Leonardo Uribe


Component unique ids generated by facelets need always to pass as params through 

UniqueIdVendor.createUniqueId(FacesContext context, String seed)

But most of the time, the only thing this call does is append the unique id prefix UIViewRoot.UNIQUE_ID_PREFIX or j_id to the seed. It has sense for programatically added component ids but is complete worthless for facelets added components, because in this case there is a global strategy to keep uniqueness of components without rely on UniqueIdVendor logic.

The big question is if we can set it by default. There is nothing in the spec that forces us to do it......

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MYFACES-3561) [perf] skip UniqueIdVendor.createUniqueId(FacesContext context, String seed) for facelets generated component ids

Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-3561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289282#comment-13289282 ] 

Leonardo Uribe commented on MYFACES-3561:
-----------------------------------------

I checked again the idea and the improvement is very small from memory perspective, because other improvements already done in that area minimize its effect. The effect from speed perspective will be minimal too. It is a good idea but there is no need to include it for now.
                
> [perf] skip UniqueIdVendor.createUniqueId(FacesContext context, String seed) for facelets generated component ids
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-3561
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3561
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: JSR-314
>            Reporter: Leonardo Uribe
>         Attachments: MYFACES-3561-1.patch, MYFACES-3561-2.patch
>
>
> Component unique ids generated by facelets need always to pass as params through 
> UniqueIdVendor.createUniqueId(FacesContext context, String seed)
> But most of the time, the only thing this call does is append the unique id prefix UIViewRoot.UNIQUE_ID_PREFIX or j_id to the seed. It has sense for programatically added component ids but is complete worthless for facelets added components, because in this case there is a global strategy to keep uniqueness of components without rely on UniqueIdVendor logic.
> The big question is if we can set it by default. There is nothing in the spec that forces us to do it......

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (MYFACES-3561) [perf] skip UniqueIdVendor.createUniqueId(FacesContext context, String seed) for facelets generated component ids

Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/MYFACES-3561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leonardo Uribe updated MYFACES-3561:
------------------------------------

    Status: Patch Available  (was: Open)
    
> [perf] skip UniqueIdVendor.createUniqueId(FacesContext context, String seed) for facelets generated component ids
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-3561
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3561
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: JSR-314
>            Reporter: Leonardo Uribe
>         Attachments: MYFACES-3561-1.patch
>
>
> Component unique ids generated by facelets need always to pass as params through 
> UniqueIdVendor.createUniqueId(FacesContext context, String seed)
> But most of the time, the only thing this call does is append the unique id prefix UIViewRoot.UNIQUE_ID_PREFIX or j_id to the seed. It has sense for programatically added component ids but is complete worthless for facelets added components, because in this case there is a global strategy to keep uniqueness of components without rely on UniqueIdVendor logic.
> The big question is if we can set it by default. There is nothing in the spec that forces us to do it......

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira