You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/06/25 00:10:13 UTC
Review Request 35849: Added a precision test for Resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35849/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
Repository: mesos
Description
-------
Added a precision test for Resources.
Diffs
-----
src/tests/resources_tests.cpp 9f96b14a6a4ce416d044934dd7ab4d28e4bc7332
Diff: https://reviews.apache.org/r/35849/diff/
Testing
-------
Currently disabled. If enabled:
```
[ RUN ] ResourcesTest.Precision
../../../mesos/src/tests/resources_tests.cpp:943: Failure
Value of: r2
Actual: { cpus(*):0.1 }
Expected: r1
Which is: { cpus(*):0.1 }
[ FAILED ] ResourcesTest.Precision (0 ms)
```
Thanks,
Jie Yu
Re: Review Request 35849: Added a precision test for Resources.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35849/#review89260
-----------------------------------------------------------
src/tests/resources_tests.cpp (lines 936 - 944)
<https://reviews.apache.org/r/35849/#comment141852>
Mind leaving a note for posterity as to why it's disabled? E.g.
```
// NOTE: This is disabled due to MESOS-1187.
```
- Ben Mahler
On June 24, 2015, 10:10 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35849/
> -----------------------------------------------------------
>
> (Updated June 24, 2015, 10:10 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Bugs: MESOS-1187
> https://issues.apache.org/jira/browse/MESOS-1187
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a precision test for Resources.
>
>
> Diffs
> -----
>
> src/tests/resources_tests.cpp 9f96b14a6a4ce416d044934dd7ab4d28e4bc7332
>
> Diff: https://reviews.apache.org/r/35849/diff/
>
>
> Testing
> -------
>
> Currently disabled. If enabled:
>
> ```
> [ RUN ] ResourcesTest.Precision
> ../../../mesos/src/tests/resources_tests.cpp:943: Failure
> Value of: r2
> Actual: { cpus(*):0.1 }
> Expected: r1
> Which is: { cpus(*):0.1 }
> [ FAILED ] ResourcesTest.Precision (0 ms)
> ```
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 35849: Added a precision test for Resources.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35849/#review89261
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On June 24, 2015, 10:10 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35849/
> -----------------------------------------------------------
>
> (Updated June 24, 2015, 10:10 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Bugs: MESOS-1187
> https://issues.apache.org/jira/browse/MESOS-1187
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a precision test for Resources.
>
>
> Diffs
> -----
>
> src/tests/resources_tests.cpp 9f96b14a6a4ce416d044934dd7ab4d28e4bc7332
>
> Diff: https://reviews.apache.org/r/35849/diff/
>
>
> Testing
> -------
>
> Currently disabled. If enabled:
>
> ```
> [ RUN ] ResourcesTest.Precision
> ../../../mesos/src/tests/resources_tests.cpp:943: Failure
> Value of: r2
> Actual: { cpus(*):0.1 }
> Expected: r1
> Which is: { cpus(*):0.1 }
> [ FAILED ] ResourcesTest.Precision (0 ms)
> ```
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 35849: Added a precision test for Resources.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35849/#review89296
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35849]
All tests passed.
- Mesos ReviewBot
On June 24, 2015, 10:10 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35849/
> -----------------------------------------------------------
>
> (Updated June 24, 2015, 10:10 p.m.)
>
>
> Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
>
>
> Bugs: MESOS-1187
> https://issues.apache.org/jira/browse/MESOS-1187
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a precision test for Resources.
>
>
> Diffs
> -----
>
> src/tests/resources_tests.cpp 9f96b14a6a4ce416d044934dd7ab4d28e4bc7332
>
> Diff: https://reviews.apache.org/r/35849/diff/
>
>
> Testing
> -------
>
> Currently disabled. If enabled:
>
> ```
> [ RUN ] ResourcesTest.Precision
> ../../../mesos/src/tests/resources_tests.cpp:943: Failure
> Value of: r2
> Actual: { cpus(*):0.1 }
> Expected: r1
> Which is: { cpus(*):0.1 }
> [ FAILED ] ResourcesTest.Precision (0 ms)
> ```
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 35849: Added a precision test for Resources.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35849/
-----------------------------------------------------------
(Updated June 24, 2015, 10:10 p.m.)
Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone.
Bugs: MESOS-1187
https://issues.apache.org/jira/browse/MESOS-1187
Repository: mesos
Description
-------
Added a precision test for Resources.
Diffs
-----
src/tests/resources_tests.cpp 9f96b14a6a4ce416d044934dd7ab4d28e4bc7332
Diff: https://reviews.apache.org/r/35849/diff/
Testing
-------
Currently disabled. If enabled:
```
[ RUN ] ResourcesTest.Precision
../../../mesos/src/tests/resources_tests.cpp:943: Failure
Value of: r2
Actual: { cpus(*):0.1 }
Expected: r1
Which is: { cpus(*):0.1 }
[ FAILED ] ResourcesTest.Precision (0 ms)
```
Thanks,
Jie Yu