You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ScrapCodes <gi...@git.apache.org> on 2014/11/19 12:13:34 UTC
[GitHub] spark pull request: [BUILD] Mvn with zinc support, this script wil...
GitHub user ScrapCodes opened a pull request:
https://github.com/apache/spark/pull/3364
[BUILD] Mvn with zinc support, this script will autodownload zinc and setup for you.
You just have to run maven as mvn/mvn and other params as usual.
for example
mvn/mvn clean install -DskipTests
I haven't done the benchmark, but should be better.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ScrapCodes/spark-1 zinc-maven
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/3364.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3364
----
commit c0712b5ba8064fbf93d7f713d9d11f176686f81e
Author: Prashant Sharma <pr...@imaginea.com>
Date: 2014-11-19T11:11:10Z
mvn with zinc support, this script will autodownload zinc and setup for you.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [BUILD] Maven with zinc support, this script w...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/3364#issuecomment-66536232
Let's close this issue since it's being picked up by someone else.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [BUILD] Maven with zinc support, this script w...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3364
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [BUILD] Maven with zinc support, this script w...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3364#issuecomment-63625684
[Test build #23609 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23609/consoleFull) for PR 3364 at commit [`c0712b5`](https://github.com/apache/spark/commit/c0712b5ba8064fbf93d7f713d9d11f176686f81e).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [BUILD] Maven with zinc support, this script w...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3364#issuecomment-63627903
I think this would perhaps interfere with local zinc? I already run my own. Does this fail if zinc can't be found or run?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [BUILD] Maven with zinc support, this script w...
Posted by markhamstra <gi...@git.apache.org>.
Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/3364#issuecomment-63665832
@srowen Looks like it would install the tarball in spark/mvn/target, but not actually run anything if it detects an already running instance of zinc; so it shouldn't negatively affect those of us already running zinc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [BUILD] Maven with zinc support, this script w...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/3364#issuecomment-63733893
@srowen @markhamstra - I made a JIRA with some suggestions about how this could work (https://issues.apache.org/jira/browse/SPARK-4501). We definitely shouldn't interfere with users who have their own build set-up. My hope was to have something a bit more general that would download maven and zinc for users who want to bootstrap from nothing but having Java. This would be very useful for jenkins build environment as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [BUILD] Maven with zinc support, this script w...
Posted by ScrapCodes <gi...@git.apache.org>.
Github user ScrapCodes commented on the pull request:
https://github.com/apache/spark/pull/3364#issuecomment-63624974
@pwendell Please take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [BUILD] Maven with zinc support, this script w...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3364#issuecomment-63634655
[Test build #23609 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23609/consoleFull) for PR 3364 at commit [`c0712b5`](https://github.com/apache/spark/commit/c0712b5ba8064fbf93d7f713d9d11f176686f81e).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [BUILD] Maven with zinc support, this script w...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3364#issuecomment-63634661
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23609/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org