You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/09/09 17:55:08 UTC
[GitHub] [maven-integration-testing] MartinKanters opened a new pull request #71: [MNG-6981] Include child projects of projects selected with --pl
MartinKanters opened a new pull request #71:
URL: https://github.com/apache/maven-integration-testing/pull/71
Related JIRA issue: https://issues.apache.org/jira/browse/MNG-6981.
PR for implementation is here: https://github.com/apache/maven/pull/374.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on a change in pull request #71: [MNG-6981] Include child projects of projects selected with --pl
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #71:
URL: https://github.com/apache/maven-integration-testing/pull/71#discussion_r487527427
##########
File path: core-it-suite/src/test/resources/mng-6981-pl-should-include-children/module-a/module-a-1/pom.xml
##########
@@ -0,0 +1,36 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
Review comment:
http://maven.apache.org/xsd/maven-4.0.0.xsd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] MartinKanters commented on a change in pull request #71: [MNG-6981] Include child projects of projects selected with --pl
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on a change in pull request #71:
URL: https://github.com/apache/maven-integration-testing/pull/71#discussion_r487527101
##########
File path: core-it-suite/src/test/resources/mng-6981-pl-should-include-children/module-a/module-a-1/pom.xml
##########
@@ -0,0 +1,36 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
Review comment:
Hmm, I'm afraid I don't know enough of XML to understand what you mean. I have also checked some other POMs in the repo and they are quite similar (some are missing these three attributes completely).
Can you please give me a pointer here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] MartinKanters commented on a change in pull request #71: [MNG-6981] Include child projects of projects selected with --pl
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on a change in pull request #71:
URL: https://github.com/apache/maven-integration-testing/pull/71#discussion_r487536056
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4262MakeLikeReactorDottedPathTest.java
##########
@@ -64,7 +64,6 @@ public void testitMakeRoot()
verifier.resetStreams();
verifier.assertFilePresent( "target/touch.txt" );
- verifier.assertFileNotPresent( "../sub-a/target/touch.txt" );
Review comment:
I have not found assertions with version scopes, but I've found the method `matchesVersionString` which I applied. I have verified it by running Maven 3.6.3 and the MNG-6981 PR against the ITs. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] MartinKanters commented on a change in pull request #71: [MNG-6981] Include child projects of projects selected with --pl
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on a change in pull request #71:
URL: https://github.com/apache/maven-integration-testing/pull/71#discussion_r487544120
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4262MakeLikeReactorDottedPathTest.java
##########
@@ -64,7 +64,6 @@ public void testitMakeRoot()
verifier.resetStreams();
verifier.assertFilePresent( "target/touch.txt" );
- verifier.assertFileNotPresent( "../sub-a/target/touch.txt" );
Review comment:
Ah, that's right, I forgot about that. Too bad we'll duplicate the tests then, but it makes sense to have the old tests 'immutable'. I took your advice, @rfscholte , this is what you meant, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] MartinKanters closed pull request #71: [MNG-6981] Include child projects of projects selected with --pl
Posted by GitBox <gi...@apache.org>.
MartinKanters closed pull request #71:
URL: https://github.com/apache/maven-integration-testing/pull/71
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] MartinKanters commented on a change in pull request #71: [MNG-6981] Include child projects of projects selected with --pl
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on a change in pull request #71:
URL: https://github.com/apache/maven-integration-testing/pull/71#discussion_r487408127
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6981ProjectListShouldIncludeChildrenTest.java
##########
@@ -0,0 +1,68 @@
+package org.apache.maven.it;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+import java.util.List;
+
+public class MavenITmng6981ProjectListShouldIncludeChildrenTest
+ extends AbstractMavenIntegrationTestCase
+{
+
+ private static final String RESOURCE_PATH = "/mng-6981-pl-should-include-children";
+
+ public MavenITmng6981ProjectListShouldIncludeChildrenTest()
+ {
+ super( "[3.7.0,)" );
+ }
+
+ public void testProjectListShouldIncludeChildrenByDefault()
+ throws Exception
+ {
+ final File testDir = ResourceExtractor.simpleExtractResources( getClass(), RESOURCE_PATH );
+ Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+
+ verifier.addCliOption( "-pl" );
+ verifier.addCliOption( ":module-a" );
+ verifier.executeGoal( "compile" );
+ verifier.verifyTextInLog( "Building module-a-1 1.0" );
+ }
+
+ /**
+ * Since --pl's behavior is changed, make sure the alternative for building a pom without it's children still works.
Review comment:
Good idea. I have created a [PR on maven-site](https://github.com/apache/maven-site/pull/199) about this alternative, but also some other docs that were missing. Is this what you had in mind?
I think we should extend the PR with more documentation related to the other reactor changes coming in 3.7.0.
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6981ProjectListShouldIncludeChildrenTest.java
##########
@@ -0,0 +1,68 @@
+package org.apache.maven.it;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+import java.util.List;
+
+public class MavenITmng6981ProjectListShouldIncludeChildrenTest
+ extends AbstractMavenIntegrationTestCase
+{
+
+ private static final String RESOURCE_PATH = "/mng-6981-pl-should-include-children";
+
+ public MavenITmng6981ProjectListShouldIncludeChildrenTest()
+ {
+ super( "[3.7.0,)" );
+ }
+
+ public void testProjectListShouldIncludeChildrenByDefault()
+ throws Exception
+ {
+ final File testDir = ResourceExtractor.simpleExtractResources( getClass(), RESOURCE_PATH );
+ Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+
+ verifier.addCliOption( "-pl" );
+ verifier.addCliOption( ":module-a" );
+ verifier.executeGoal( "compile" );
+ verifier.verifyTextInLog( "Building module-a-1 1.0" );
+ }
+
+ /**
+ * Since --pl's behavior is changed, make sure the alternative for building a pom without it's children still works.
Review comment:
Good idea. I have created a [PR on maven-site](https://github.com/apache/maven-site/pull/199) about this alternative, but also some other docs that were missing. Is this what you had in mind?
I think we should extend the PR with more documentation related to the other reactor changes coming in 3.7.0.
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6981ProjectListShouldIncludeChildrenTest.java
##########
@@ -0,0 +1,68 @@
+package org.apache.maven.it;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+import java.util.List;
+
+public class MavenITmng6981ProjectListShouldIncludeChildrenTest
+ extends AbstractMavenIntegrationTestCase
+{
+
+ private static final String RESOURCE_PATH = "/mng-6981-pl-should-include-children";
+
+ public MavenITmng6981ProjectListShouldIncludeChildrenTest()
+ {
+ super( "[3.7.0,)" );
+ }
+
+ public void testProjectListShouldIncludeChildrenByDefault()
+ throws Exception
+ {
+ final File testDir = ResourceExtractor.simpleExtractResources( getClass(), RESOURCE_PATH );
+ Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+
+ verifier.addCliOption( "-pl" );
+ verifier.addCliOption( ":module-a" );
+ verifier.executeGoal( "compile" );
+ verifier.verifyTextInLog( "Building module-a-1 1.0" );
+ }
+
+ /**
+ * Since --pl's behavior is changed, make sure the alternative for building a pom without it's children still works.
Review comment:
Good idea. I have created a [PR on maven-site](https://github.com/apache/maven-site/pull/199) about this alternative, but also some other docs that were missing. Is this what you had in mind?
I think we should extend the PR with more documentation related to the other reactor changes coming in 3.7.0.
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6981ProjectListShouldIncludeChildrenTest.java
##########
@@ -0,0 +1,68 @@
+package org.apache.maven.it;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+import java.util.List;
+
+public class MavenITmng6981ProjectListShouldIncludeChildrenTest
+ extends AbstractMavenIntegrationTestCase
+{
+
+ private static final String RESOURCE_PATH = "/mng-6981-pl-should-include-children";
+
+ public MavenITmng6981ProjectListShouldIncludeChildrenTest()
+ {
+ super( "[3.7.0,)" );
+ }
+
+ public void testProjectListShouldIncludeChildrenByDefault()
+ throws Exception
+ {
+ final File testDir = ResourceExtractor.simpleExtractResources( getClass(), RESOURCE_PATH );
+ Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+
+ verifier.addCliOption( "-pl" );
+ verifier.addCliOption( ":module-a" );
+ verifier.executeGoal( "compile" );
+ verifier.verifyTextInLog( "Building module-a-1 1.0" );
+ }
+
+ /**
+ * Since --pl's behavior is changed, make sure the alternative for building a pom without it's children still works.
Review comment:
Good idea. I have created a [PR on maven-site](https://github.com/apache/maven-site/pull/199) about this alternative, but also some other docs that were missing. Is this what you had in mind?
I think we should extend the PR with more documentation related to the other reactor changes coming in 3.7.0.
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6981ProjectListShouldIncludeChildrenTest.java
##########
@@ -0,0 +1,68 @@
+package org.apache.maven.it;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+import java.util.List;
+
+public class MavenITmng6981ProjectListShouldIncludeChildrenTest
+ extends AbstractMavenIntegrationTestCase
+{
+
+ private static final String RESOURCE_PATH = "/mng-6981-pl-should-include-children";
+
+ public MavenITmng6981ProjectListShouldIncludeChildrenTest()
+ {
+ super( "[3.7.0,)" );
+ }
+
+ public void testProjectListShouldIncludeChildrenByDefault()
+ throws Exception
+ {
+ final File testDir = ResourceExtractor.simpleExtractResources( getClass(), RESOURCE_PATH );
+ Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+
+ verifier.addCliOption( "-pl" );
+ verifier.addCliOption( ":module-a" );
+ verifier.executeGoal( "compile" );
+ verifier.verifyTextInLog( "Building module-a-1 1.0" );
+ }
+
+ /**
+ * Since --pl's behavior is changed, make sure the alternative for building a pom without it's children still works.
Review comment:
Good idea. I have created a [PR on maven-site](https://github.com/apache/maven-site/pull/199) about this alternative, but also some other docs that were missing. Is this what you had in mind?
I think we should extend the PR with more documentation related to the other reactor changes coming in 3.7.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on a change in pull request #71: [MNG-6981] Include child projects of projects selected with --pl
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #71:
URL: https://github.com/apache/maven-integration-testing/pull/71#discussion_r487527055
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4262MakeLikeReactorDottedPathTest.java
##########
@@ -64,7 +64,6 @@ public void testitMakeRoot()
verifier.resetStreams();
verifier.assertFilePresent( "target/touch.txt" );
- verifier.assertFileNotPresent( "../sub-a/target/touch.txt" );
Review comment:
Does the test still pass with 3.6.3? The are assertions which can be scoped with version ranges. Maybe we could utilize them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] mthmulders commented on a change in pull request #71: [MNG-6981] Include child projects of projects selected with --pl
Posted by GitBox <gi...@apache.org>.
mthmulders commented on a change in pull request #71:
URL: https://github.com/apache/maven-integration-testing/pull/71#discussion_r486084663
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6981ProjectListShouldIncludeChildrenTest.java
##########
@@ -0,0 +1,68 @@
+package org.apache.maven.it;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+import java.util.List;
+
+public class MavenITmng6981ProjectListShouldIncludeChildrenTest
+ extends AbstractMavenIntegrationTestCase
+{
+
+ private static final String RESOURCE_PATH = "/mng-6981-pl-should-include-children";
+
+ public MavenITmng6981ProjectListShouldIncludeChildrenTest()
+ {
+ super( "[3.7.0,)" );
+ }
+
+ public void testProjectListShouldIncludeChildrenByDefault()
+ throws Exception
+ {
+ final File testDir = ResourceExtractor.simpleExtractResources( getClass(), RESOURCE_PATH );
+ Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+
+ verifier.addCliOption( "-pl" );
+ verifier.addCliOption( ":module-a" );
+ verifier.executeGoal( "compile" );
+ verifier.verifyTextInLog( "Building module-a-1 1.0" );
+ }
+
+ /**
+ * Since --pl's behavior is changed, make sure the alternative for building a pom without it's children still works.
Review comment:
I think this should be in the documentation somewhere, too. Not just here in a Javadoc, but maybe in the [Guide to Working with Multiple Modules](https://maven.apache.org/guides/mini/guide-multiple-modules.html)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] rfscholte commented on a change in pull request #71: [MNG-6981] Include child projects of projects selected with --pl
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #71:
URL: https://github.com/apache/maven-integration-testing/pull/71#discussion_r487547582
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4262MakeLikeReactorDottedPathTest.java
##########
@@ -64,7 +64,6 @@ public void testitMakeRoot()
verifier.resetStreams();
verifier.assertFilePresent( "target/touch.txt" );
- verifier.assertFileNotPresent( "../sub-a/target/touch.txt" );
Review comment:
Almost correct, you should only adjust the value in the constructor, this one should be
super( "(,3.7.0)" );
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] rfscholte commented on pull request #71: [MNG-6981] Include child projects of projects selected with --pl
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #71:
URL: https://github.com/apache/maven-integration-testing/pull/71#issuecomment-709901869
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] rfscholte commented on a change in pull request #71: [MNG-6981] Include child projects of projects selected with --pl
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #71:
URL: https://github.com/apache/maven-integration-testing/pull/71#discussion_r487539681
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4262MakeLikeReactorDottedPathTest.java
##########
@@ -64,7 +64,6 @@ public void testitMakeRoot()
verifier.resetStreams();
verifier.assertFilePresent( "target/touch.txt" );
- verifier.assertFileNotPresent( "../sub-a/target/touch.txt" );
Review comment:
The general rule is that you should never adjust the test itself. If the behavior changes, adjust the Maven versionsRange and make a new integrationtest for it (with the new behavior)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on a change in pull request #71: [MNG-6981] Include child projects of projects selected with --pl
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #71:
URL: https://github.com/apache/maven-integration-testing/pull/71#discussion_r487536624
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4262MakeLikeReactorDottedPathTest.java
##########
@@ -64,7 +64,6 @@ public void testitMakeRoot()
verifier.resetStreams();
verifier.assertFilePresent( "target/touch.txt" );
- verifier.assertFileNotPresent( "../sub-a/target/touch.txt" );
Review comment:
That's exactly what I was referring to!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on a change in pull request #71: [MNG-6981] Include child projects of projects selected with --pl
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #71:
URL: https://github.com/apache/maven-integration-testing/pull/71#discussion_r487503260
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4262MakeLikeReactorDottedPathTest.java
##########
@@ -64,7 +64,6 @@ public void testitMakeRoot()
verifier.resetStreams();
verifier.assertFilePresent( "target/touch.txt" );
- verifier.assertFileNotPresent( "../sub-a/target/touch.txt" );
Review comment:
Why is this one gone?
##########
File path: core-it-suite/src/test/resources/mng-6981-pl-should-include-children/module-a/module-a-1/pom.xml
##########
@@ -0,0 +1,36 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
Review comment:
Please use the canonical schema location, not the old one.
##########
File path: core-it-suite/src/test/resources/mng-6981-pl-should-include-children/module-a/pom.xml
##########
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
Review comment:
same here.
##########
File path: core-it-suite/src/test/resources/mng-6981-pl-should-include-children/pom.xml
##########
@@ -0,0 +1,48 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
Review comment:
same here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] MartinKanters commented on a change in pull request #71: [MNG-6981] Include child projects of projects selected with --pl
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on a change in pull request #71:
URL: https://github.com/apache/maven-integration-testing/pull/71#discussion_r487550812
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4262MakeLikeReactorDottedPathTest.java
##########
@@ -64,7 +64,6 @@ public void testitMakeRoot()
verifier.resetStreams();
verifier.assertFilePresent( "target/touch.txt" );
- verifier.assertFileNotPresent( "../sub-a/target/touch.txt" );
Review comment:
Oh.. my `git push` didn't get through... I've pushed the changes now. Please take another look..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] MartinKanters commented on a change in pull request #71: [MNG-6981] Include child projects of projects selected with --pl
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on a change in pull request #71:
URL: https://github.com/apache/maven-integration-testing/pull/71#discussion_r487535747
##########
File path: core-it-suite/src/test/resources/mng-6981-pl-should-include-children/module-a/module-a-1/pom.xml
##########
@@ -0,0 +1,36 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
Review comment:
Thanks! I've changed them
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] MartinKanters commented on a change in pull request #71: [MNG-6981] Include child projects of projects selected with --pl
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on a change in pull request #71:
URL: https://github.com/apache/maven-integration-testing/pull/71#discussion_r487408127
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6981ProjectListShouldIncludeChildrenTest.java
##########
@@ -0,0 +1,68 @@
+package org.apache.maven.it;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+import java.util.List;
+
+public class MavenITmng6981ProjectListShouldIncludeChildrenTest
+ extends AbstractMavenIntegrationTestCase
+{
+
+ private static final String RESOURCE_PATH = "/mng-6981-pl-should-include-children";
+
+ public MavenITmng6981ProjectListShouldIncludeChildrenTest()
+ {
+ super( "[3.7.0,)" );
+ }
+
+ public void testProjectListShouldIncludeChildrenByDefault()
+ throws Exception
+ {
+ final File testDir = ResourceExtractor.simpleExtractResources( getClass(), RESOURCE_PATH );
+ Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+
+ verifier.addCliOption( "-pl" );
+ verifier.addCliOption( ":module-a" );
+ verifier.executeGoal( "compile" );
+ verifier.verifyTextInLog( "Building module-a-1 1.0" );
+ }
+
+ /**
+ * Since --pl's behavior is changed, make sure the alternative for building a pom without it's children still works.
Review comment:
Good idea. I have created a [PR on maven-site](https://github.com/apache/maven-site/pull/199) about this alternative, but also some other docs that were missing. Is this what you had in mind?
I think we should extend the PR with more documentation related to the other reactor changes coming in 3.7.0.
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6981ProjectListShouldIncludeChildrenTest.java
##########
@@ -0,0 +1,68 @@
+package org.apache.maven.it;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+import java.util.List;
+
+public class MavenITmng6981ProjectListShouldIncludeChildrenTest
+ extends AbstractMavenIntegrationTestCase
+{
+
+ private static final String RESOURCE_PATH = "/mng-6981-pl-should-include-children";
+
+ public MavenITmng6981ProjectListShouldIncludeChildrenTest()
+ {
+ super( "[3.7.0,)" );
+ }
+
+ public void testProjectListShouldIncludeChildrenByDefault()
+ throws Exception
+ {
+ final File testDir = ResourceExtractor.simpleExtractResources( getClass(), RESOURCE_PATH );
+ Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+
+ verifier.addCliOption( "-pl" );
+ verifier.addCliOption( ":module-a" );
+ verifier.executeGoal( "compile" );
+ verifier.verifyTextInLog( "Building module-a-1 1.0" );
+ }
+
+ /**
+ * Since --pl's behavior is changed, make sure the alternative for building a pom without it's children still works.
Review comment:
Good idea. I have created a [PR on maven-site](https://github.com/apache/maven-site/pull/199) about this alternative, but also some other docs that were missing. Is this what you had in mind?
I think we should extend the PR with more documentation related to the other reactor changes coming in 3.7.0.
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6981ProjectListShouldIncludeChildrenTest.java
##########
@@ -0,0 +1,68 @@
+package org.apache.maven.it;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+import java.util.List;
+
+public class MavenITmng6981ProjectListShouldIncludeChildrenTest
+ extends AbstractMavenIntegrationTestCase
+{
+
+ private static final String RESOURCE_PATH = "/mng-6981-pl-should-include-children";
+
+ public MavenITmng6981ProjectListShouldIncludeChildrenTest()
+ {
+ super( "[3.7.0,)" );
+ }
+
+ public void testProjectListShouldIncludeChildrenByDefault()
+ throws Exception
+ {
+ final File testDir = ResourceExtractor.simpleExtractResources( getClass(), RESOURCE_PATH );
+ Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+
+ verifier.addCliOption( "-pl" );
+ verifier.addCliOption( ":module-a" );
+ verifier.executeGoal( "compile" );
+ verifier.verifyTextInLog( "Building module-a-1 1.0" );
+ }
+
+ /**
+ * Since --pl's behavior is changed, make sure the alternative for building a pom without it's children still works.
Review comment:
Good idea. I have created a [PR on maven-site](https://github.com/apache/maven-site/pull/199) about this alternative, but also some other docs that were missing. Is this what you had in mind?
I think we should extend the PR with more documentation related to the other reactor changes coming in 3.7.0.
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6981ProjectListShouldIncludeChildrenTest.java
##########
@@ -0,0 +1,68 @@
+package org.apache.maven.it;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+import java.util.List;
+
+public class MavenITmng6981ProjectListShouldIncludeChildrenTest
+ extends AbstractMavenIntegrationTestCase
+{
+
+ private static final String RESOURCE_PATH = "/mng-6981-pl-should-include-children";
+
+ public MavenITmng6981ProjectListShouldIncludeChildrenTest()
+ {
+ super( "[3.7.0,)" );
+ }
+
+ public void testProjectListShouldIncludeChildrenByDefault()
+ throws Exception
+ {
+ final File testDir = ResourceExtractor.simpleExtractResources( getClass(), RESOURCE_PATH );
+ Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+
+ verifier.addCliOption( "-pl" );
+ verifier.addCliOption( ":module-a" );
+ verifier.executeGoal( "compile" );
+ verifier.verifyTextInLog( "Building module-a-1 1.0" );
+ }
+
+ /**
+ * Since --pl's behavior is changed, make sure the alternative for building a pom without it's children still works.
Review comment:
Good idea. I have created a [PR on maven-site](https://github.com/apache/maven-site/pull/199) about this alternative, but also some other docs that were missing. Is this what you had in mind?
I think we should extend the PR with more documentation related to the other reactor changes coming in 3.7.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] MartinKanters commented on a change in pull request #71: [MNG-6981] Include child projects of projects selected with --pl
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on a change in pull request #71:
URL: https://github.com/apache/maven-integration-testing/pull/71#discussion_r487408127
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6981ProjectListShouldIncludeChildrenTest.java
##########
@@ -0,0 +1,68 @@
+package org.apache.maven.it;
+
+import org.apache.maven.it.util.ResourceExtractor;
+
+import java.io.File;
+import java.util.List;
+
+public class MavenITmng6981ProjectListShouldIncludeChildrenTest
+ extends AbstractMavenIntegrationTestCase
+{
+
+ private static final String RESOURCE_PATH = "/mng-6981-pl-should-include-children";
+
+ public MavenITmng6981ProjectListShouldIncludeChildrenTest()
+ {
+ super( "[3.7.0,)" );
+ }
+
+ public void testProjectListShouldIncludeChildrenByDefault()
+ throws Exception
+ {
+ final File testDir = ResourceExtractor.simpleExtractResources( getClass(), RESOURCE_PATH );
+ Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+
+ verifier.addCliOption( "-pl" );
+ verifier.addCliOption( ":module-a" );
+ verifier.executeGoal( "compile" );
+ verifier.verifyTextInLog( "Building module-a-1 1.0" );
+ }
+
+ /**
+ * Since --pl's behavior is changed, make sure the alternative for building a pom without it's children still works.
Review comment:
Good idea. I have created a [PR on maven-site](https://github.com/apache/maven-site/pull/199) about this alternative, but also some other docs that were missing. Is this what you had in mind?
I think we should extend the PR with more documentation related to the other reactor changes coming in 3.7.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] MartinKanters commented on a change in pull request #71: [MNG-6981] Include child projects of projects selected with --pl
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on a change in pull request #71:
URL: https://github.com/apache/maven-integration-testing/pull/71#discussion_r487526420
##########
File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4262MakeLikeReactorDottedPathTest.java
##########
@@ -64,7 +64,6 @@ public void testitMakeRoot()
verifier.resetStreams();
verifier.assertFilePresent( "target/touch.txt" );
- verifier.assertFileNotPresent( "../sub-a/target/touch.txt" );
Review comment:
This test used to verify that if you execute `mvn <goal> -pl .` that root is built (line 66) and that the subproject is not built (line 67).
The change in MNG-6981 changed the behavior of `-pl`. First it didn't build the target project's children, now it does.
I decided to remove the assertion on line 67, since it is in my opinion an unnecessary assertion which is not related to unit test. Also by removing the assertion we make sure that this test will work pre and post MNG-6981. Alternatively we could duplicate the test class with different version restrictions. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org