You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@flink.apache.org by "Robert Metzger (Jira)" <ji...@apache.org> on 2021/03/05 15:28:00 UTC

[jira] [Created] (FLINK-21638) Clean up argument order and semantics of all "stopWithSavepoint" calls in the codebase

Robert Metzger created FLINK-21638:
--------------------------------------

             Summary: Clean up argument order and semantics of all "stopWithSavepoint" calls in the codebase
                 Key: FLINK-21638
                 URL: https://issues.apache.org/jira/browse/FLINK-21638
             Project: Flink
          Issue Type: Improvement
          Components: Client / Job Submission, Runtime / Coordination
            Reporter: Robert Metzger
             Fix For: 1.13.0


This came up in a review: https://github.com/apache/flink/pull/14948#discussion_r588304475

The stopWithSavepoint() methods in Flink have a boolean flag, indicating either whether we inject a MAX_WATERMARK in the pipeline, or whether we terminate or suspend a job. 

As part of this ticket, I propose to introduce a new enum type in flink-core "StopWithSavepointBehavior" with SUSPEND and TERMINATE fields and replace the boolean flag with this new field.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)