You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by al...@apache.org on 2016/11/24 16:48:25 UTC
[2/2] mesos git commit: Improved comments around health checks in
mesos.proto.
Improved comments around health checks in mesos.proto.
Review: https://reviews.apache.org/r/53611/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/8fd64fd5
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/8fd64fd5
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/8fd64fd5
Branch: refs/heads/master
Commit: 8fd64fd5efb898baf99a74ea9104205969d9807b
Parents: b18ae54
Author: Alexander Rukletsov <ru...@gmail.com>
Authored: Thu Nov 24 17:47:39 2016 +0100
Committer: Alexander Rukletsov <al...@apache.org>
Committed: Thu Nov 24 17:47:39 2016 +0100
----------------------------------------------------------------------
include/mesos/mesos.proto | 13 +++++++++----
include/mesos/v1/mesos.proto | 13 +++++++++----
2 files changed, 18 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/8fd64fd5/include/mesos/mesos.proto
----------------------------------------------------------------------
diff --git a/include/mesos/mesos.proto b/include/mesos/mesos.proto
index 3805759..cbfcd8a 100644
--- a/include/mesos/mesos.proto
+++ b/include/mesos/mesos.proto
@@ -399,19 +399,24 @@ message HealthCheck {
// allows doing something similar to the HTTP strategy but
// encapsulates all the details in a single string field.
- // Amount of time to wait until starting the health checks.
+ // Amount of time to wait until starting health checking the task.
optional double delay_seconds = 2 [default = 15.0];
// Interval between health checks.
optional double interval_seconds = 3 [default = 10.0];
- // Amount of time to wait for the health check to complete.
+ // Amount of time to wait for the health check to complete. After this
+ // timeout, the health check is aborted and treated as a failure.
optional double timeout_seconds = 4 [default = 20.0];
- // Number of consecutive failures until signaling kill task.
+ // Number of consecutive failures until the task is killed by the executor.
optional uint32 consecutive_failures = 5 [default = 3];
- // Amount of time to allow failed health checks since launch.
+ // Amount of time after the task is launched during which health check
+ // failures are ignored. Once the a check succeeds for the first time,
+ // the grace period does not apply anymore. Note that it includes
+ // `delay_seconds`, i.e., setting `grace_period_seconds` < `delay_seconds`
+ // has no effect.
optional double grace_period_seconds = 6 [default = 10.0];
// TODO(alexr): Add an optional `KillPolicy` that should be used
http://git-wip-us.apache.org/repos/asf/mesos/blob/8fd64fd5/include/mesos/v1/mesos.proto
----------------------------------------------------------------------
diff --git a/include/mesos/v1/mesos.proto b/include/mesos/v1/mesos.proto
index 5b542ff..e4f269b 100644
--- a/include/mesos/v1/mesos.proto
+++ b/include/mesos/v1/mesos.proto
@@ -399,19 +399,24 @@ message HealthCheck {
// allows doing something similar to the HTTP strategy but
// encapsulates all the details in a single string field.
- // Amount of time to wait until starting the health checks.
+ // Amount of time to wait until starting health checking the task.
optional double delay_seconds = 2 [default = 15.0];
// Interval between health checks.
optional double interval_seconds = 3 [default = 10.0];
- // Amount of time to wait for the health check to complete.
+ // Amount of time to wait for the health check to complete. After this
+ // timeout, the health check is aborted and treated as a failure.
optional double timeout_seconds = 4 [default = 20.0];
- // Number of consecutive failures until signaling kill task.
+ // Number of consecutive failures until the task is killed by the executor.
optional uint32 consecutive_failures = 5 [default = 3];
- // Amount of time to allow failed health checks since launch.
+ // Amount of time after the task is launched during which health check
+ // failures are ignored. Once the a check succeeds for the first time,
+ // the grace period does not apply anymore. Note that it includes
+ // `delay_seconds`, i.e., setting `grace_period_seconds` < `delay_seconds`
+ // has no effect.
optional double grace_period_seconds = 6 [default = 10.0];
// TODO(alexr): Add an optional `KillPolicy` that should be used