You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Mike Percy <mp...@apache.org> on 2012/07/18 09:41:02 UTC
Review Request: FLUME-1377: ChannelProcessor clobbers exception with NPE if
Channel.getTransaction() throws
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6029/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Ensure that ChannelProcessor carefully handles exceptions thrown from getTransaction() to avoid clobbering them.
Also, avoid rethrowing RuntimeExceptions in AvroSource - instead just log them and return FAILED.
This addresses bug FLUME-1377.
https://issues.apache.org/jira/browse/FLUME-1377
Diffs
-----
flume-ng-core/pom.xml 64e7f6b
flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java 293b823
flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java 86e67b0
flume-ng-core/src/test/java/org/apache/flume/channel/TestChannelProcessor.java PRE-CREATION
Diff: https://reviews.apache.org/r/6029/diff/
Testing
-------
Existing unit tests pass. Added 2 new unit tests.
Thanks,
Mike Percy
Re: Review Request: FLUME-1377: ChannelProcessor clobbers exception with NPE
if Channel.getTransaction() throws
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6029/#review9238
-----------------------------------------------------------
Ship it!
Ship It!
- Hari Shreedharan
On July 18, 2012, 7:41 a.m., Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6029/
> -----------------------------------------------------------
>
> (Updated July 18, 2012, 7:41 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Ensure that ChannelProcessor carefully handles exceptions thrown from getTransaction() to avoid clobbering them.
>
> Also, avoid rethrowing RuntimeExceptions in AvroSource - instead just log them and return FAILED.
>
>
> This addresses bug FLUME-1377.
> https://issues.apache.org/jira/browse/FLUME-1377
>
>
> Diffs
> -----
>
> flume-ng-core/pom.xml 64e7f6b
> flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java 293b823
> flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java 86e67b0
> flume-ng-core/src/test/java/org/apache/flume/channel/TestChannelProcessor.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/6029/diff/
>
>
> Testing
> -------
>
> Existing unit tests pass. Added 2 new unit tests.
>
>
> Thanks,
>
> Mike Percy
>
>