You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Attila Magyar <am...@hortonworks.com> on 2017/03/28 08:54:45 UTC
Review Request 57986: Prune files contained in zkmigrator.jar to a
minimal set
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57986/
-----------------------------------------------------------
Review request for Ambari, Attila Doroszlai, Bal�zs Bence S�ri, Laszlo Puskas, Robert Levas, and Sebastian Toader.
Bugs: AMBARI-20601
https://issues.apache.org/jira/browse/AMBARI-20601
Repository: ambari
Description
-------
The files (classes, etcs...) in the shaded JAR come from unrelated or unneeded dependencies. This is causing bloat and may cause unnecessary licensing issues.
Diffs
-----
ambari-agent/pom.xml 292fd07
Diff: https://reviews.apache.org/r/57986/diff/1/
Testing
-------
tested new jar manually:
- kerberized cluster
- dekerberized cluster
- checked ACLs with zookeeper-client
ran ambari-agent unittests successfully
Thanks,
Attila Magyar
Re: Review Request 57986: Prune files contained in zkmigrator.jar to a
minimal set
Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57986/#review170277
-----------------------------------------------------------
Ship it!
Ship It!
- Attila Doroszlai
On March 28, 2017, 10:54 a.m., Attila Magyar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57986/
> -----------------------------------------------------------
>
> (Updated March 28, 2017, 10:54 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Bal�zs Bence S�ri, Laszlo Puskas, Robert Levas, and Sebastian Toader.
>
>
> Bugs: AMBARI-20601
> https://issues.apache.org/jira/browse/AMBARI-20601
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The files (classes, etcs...) in the shaded JAR come from unrelated or unneeded dependencies. This is causing bloat and may cause unnecessary licensing issues.
>
>
> Diffs
> -----
>
> ambari-agent/pom.xml 292fd07
>
>
> Diff: https://reviews.apache.org/r/57986/diff/1/
>
>
> Testing
> -------
>
> tested new jar manually:
> - kerberized cluster
> - dekerberized cluster
> - checked ACLs with zookeeper-client
>
> ran ambari-agent unittests successfully
>
>
> Thanks,
>
> Attila Magyar
>
>
Re: Review Request 57986: Prune files contained in zkmigrator.jar to a
minimal set
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57986/#review170314
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On March 28, 2017, 4:54 a.m., Attila Magyar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57986/
> -----------------------------------------------------------
>
> (Updated March 28, 2017, 4:54 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Bal�zs Bence S�ri, Laszlo Puskas, Robert Levas, and Sebastian Toader.
>
>
> Bugs: AMBARI-20601
> https://issues.apache.org/jira/browse/AMBARI-20601
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The files (classes, etcs...) in the shaded JAR come from unrelated or unneeded dependencies. This is causing bloat and may cause unnecessary licensing issues.
>
>
> Diffs
> -----
>
> ambari-agent/pom.xml 292fd07
>
>
> Diff: https://reviews.apache.org/r/57986/diff/1/
>
>
> Testing
> -------
>
> tested new jar manually:
> - kerberized cluster
> - dekerberized cluster
> - checked ACLs with zookeeper-client
>
> ran ambari-agent unittests successfully
>
>
> Thanks,
>
> Attila Magyar
>
>
Re: Review Request 57986: Prune files contained in zkmigrator.jar to a
minimal set
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57986/#review170279
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On March 28, 2017, 10:54 a.m., Attila Magyar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57986/
> -----------------------------------------------------------
>
> (Updated March 28, 2017, 10:54 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Bal�zs Bence S�ri, Laszlo Puskas, Robert Levas, and Sebastian Toader.
>
>
> Bugs: AMBARI-20601
> https://issues.apache.org/jira/browse/AMBARI-20601
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The files (classes, etcs...) in the shaded JAR come from unrelated or unneeded dependencies. This is causing bloat and may cause unnecessary licensing issues.
>
>
> Diffs
> -----
>
> ambari-agent/pom.xml 292fd07
>
>
> Diff: https://reviews.apache.org/r/57986/diff/1/
>
>
> Testing
> -------
>
> tested new jar manually:
> - kerberized cluster
> - dekerberized cluster
> - checked ACLs with zookeeper-client
>
> ran ambari-agent unittests successfully
>
>
> Thanks,
>
> Attila Magyar
>
>