You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@axis.apache.org by "Chintana Wilamuna (JIRA)" <ji...@apache.org> on 2008/05/22 12:03:56 UTC
[jira] Created: (AXIS2C-1157) When -Werror is in effect build break
in util/src
When -Werror is in effect build break in util/src
-------------------------------------------------
Key: AXIS2C-1157
URL: https://issues.apache.org/jira/browse/AXIS2C-1157
Project: Axis2-C
Issue Type: Bug
Components: util
Affects Versions: 1.4.0
Environment: Fedora Core 9. GCC 4.3.0
Reporter: Chintana Wilamuna
GCC complains with the following error,
hash.c:573: error: 'axutil_hash_entry_free' defined but not used
make[5]: *** [hash.lo] Error 1
Since WSF/C uses all the modules I issued the following command to see where axutil_hash_entry_free is being used,
find wsf_c -iname '*.c' | xargs grep 'axutil_hash_entry_free'
And found out that it's not being used anywhere. If it's not being used I suggest at least commenting out the function since it breaks the build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
Re: [jira] Created: (AXIS2C-1157) When -Werror is in effect build break in util/src
Posted by Dinesh Premalal <xy...@gmail.com>.
Hi All,
"Chintana Wilamuna" <ch...@gmail.com> writes:
> Um .. I don't agree. This was found because of the "new changes to
> gcc". Which is really helpful because it caught a function which is
> not used anywhere. If it's not used why it's defined in the first
> place? Why not remove it altogether until it's used somewhere.
> Otherwise it'll take us nowhere because a defined function is not used
> anywhere ;-)
If not using anywhere +1 for removing. We had a convention some time
ago to remove all unused functions.
thanks,
Dinesh
--
http://nethu.org
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
Re: [jira] Created: (AXIS2C-1157) When -Werror is in effect build
break in util/src
Posted by Manjula Peiris <ma...@wso2.com>.
I think the warning here is because it is static. Otherwise I don't
think we have a problem. So we have two options I guess. Removing the
static identifier or removing the function.
-Manjula.
On Fri, 2008-05-23 at 10:06 +0100, Steven Nairn wrote:
> The function axutil_hash_entry_free() is a static function (in both
> 1.4.0 and trunk). Therefore it can only be used in hash.c and is not
> (and cannot be) part of the API.
>
> It's not used in hash.c so I think it should be removed.
>
> Cheers,
> Steve Nairn
>
> 2008/5/23 Dimuthu Gamage <di...@gmail.com>:
> > Yea, I agreed with Milinida, There are API functions that is not used
> > anywhere inside Axis2. But used in some time codegen generated code or
> > some other places like even wsf/php. So I think it is valid to have
> > API functions not used inside axis2.
> >
> > Thanks
> > Dimuthu
> >
> > On Fri, May 23, 2008 at 10:58 AM, Milinda Pathirage
> > <mi...@gmail.com> wrote:
> >> For example take function like 'axutil_date_time_is_utc' and runa grep on
> >> Axis2/C source. This function is never used in our code. But we have
> >> implemented it and one who implement service or client might use it in
> >> his/her code. This kind of functions are there to provide consistent API to
> >> the users who use this library to write their own services/clients. So I
> >> think it's better not to use -Wunused-function flag (Currently we are using
> >> -Wall in Axis2/C build and we will have to use seperate warning flags if we
> >> encounter this kind of problems in future with new version of compilers).
> >>
> >> Thanks
> >> Milinda
> >>
> >> On Fri, May 23, 2008 at 10:39 AM, Chintana Wilamuna <ch...@gmail.com>
> >> wrote:
> >>>
> >>> On Fri, May 23, 2008 at 10:22 AM, Chintana Wilamuna <ch...@gmail.com>
> >>> wrote:
> >>>
> >>> > Um .. I don't agree. This was found because of the "new changes to
> >>> > gcc". Which is really helpful because it caught a function which is
> >>> > not used anywhere. If it's not used why it's defined in the first
> >>> > place? Why not remove it altogether until it's used somewhere.
> >>> > Otherwise it'll take us nowhere because a defined function is not used
> >>> > anywhere ;-)
> >>>
> >>> Milinda told me that there could be a function defined in axutil/axis2
> >>> etc... and that not being used anywhere throughout the code. Sorry I
> >>> didn't know that. In that case yeah, should change the build system.
> >>>
> >>> Bye,
> >>>
> >>> -Chintana
> >>>
> >>> --
> >>> http://engwar.com/
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
> >>> For additional commands, e-mail: axis-c-dev-help@ws.apache.org
> >>>
> >>
> >>
> >>
> >> --
> >> http://mpathirage.com
> >> http://wso2.org "Oxygen for Web Service Developers"
> >> http://wsaxc.blogspot.com "Web Services With Axis2/C"
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
> > For additional commands, e-mail: axis-c-dev-help@ws.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-c-dev-help@ws.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
Re: [jira] Created: (AXIS2C-1157) When -Werror is in effect build break in util/src
Posted by Milinda Pathirage <mi...@gmail.com>.
Hi,
It's my mistake, I forgot to look at the method signature. The compilation
warning can be caused by the fact that the function is static.
Thanks
Milinda
On Fri, May 23, 2008 at 2:36 PM, Steven Nairn <st...@googlemail.com>
wrote:
> The function axutil_hash_entry_free() is a static function (in both
> 1.4.0 and trunk). Therefore it can only be used in hash.c and is not
> (and cannot be) part of the API.
>
> It's not used in hash.c so I think it should be removed.
>
> Cheers,
> Steve Nairn
>
> 2008/5/23 Dimuthu Gamage <di...@gmail.com>:
> > Yea, I agreed with Milinida, There are API functions that is not used
> > anywhere inside Axis2. But used in some time codegen generated code or
> > some other places like even wsf/php. So I think it is valid to have
> > API functions not used inside axis2.
> >
> > Thanks
> > Dimuthu
> >
> > On Fri, May 23, 2008 at 10:58 AM, Milinda Pathirage
> > <mi...@gmail.com> wrote:
> >> For example take function like 'axutil_date_time_is_utc' and runa grep
> on
> >> Axis2/C source. This function is never used in our code. But we have
> >> implemented it and one who implement service or client might use it in
> >> his/her code. This kind of functions are there to provide consistent API
> to
> >> the users who use this library to write their own services/clients. So I
> >> think it's better not to use -Wunused-function flag (Currently we are
> using
> >> -Wall in Axis2/C build and we will have to use seperate warning flags if
> we
> >> encounter this kind of problems in future with new version of
> compilers).
> >>
> >> Thanks
> >> Milinda
> >>
> >> On Fri, May 23, 2008 at 10:39 AM, Chintana Wilamuna <
> chintanaw@gmail.com>
> >> wrote:
> >>>
> >>> On Fri, May 23, 2008 at 10:22 AM, Chintana Wilamuna <
> chintanaw@gmail.com>
> >>> wrote:
> >>>
> >>> > Um .. I don't agree. This was found because of the "new changes to
> >>> > gcc". Which is really helpful because it caught a function which is
> >>> > not used anywhere. If it's not used why it's defined in the first
> >>> > place? Why not remove it altogether until it's used somewhere.
> >>> > Otherwise it'll take us nowhere because a defined function is not
> used
> >>> > anywhere ;-)
> >>>
> >>> Milinda told me that there could be a function defined in axutil/axis2
> >>> etc... and that not being used anywhere throughout the code. Sorry I
> >>> didn't know that. In that case yeah, should change the build system.
> >>>
> >>> Bye,
> >>>
> >>> -Chintana
> >>>
> >>> --
> >>> http://engwar.com/
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
> >>> For additional commands, e-mail: axis-c-dev-help@ws.apache.org
> >>>
> >>
> >>
> >>
> >> --
> >> http://mpathirage.com
> >> http://wso2.org "Oxygen for Web Service Developers"
> >> http://wsaxc.blogspot.com "Web Services With Axis2/C"
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
> > For additional commands, e-mail: axis-c-dev-help@ws.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-c-dev-help@ws.apache.org
>
>
--
http://mpathirage.com
http://wso2.org "Oxygen for Web Service Developers"
http://wsaxc.blogspot.com "Web Services With Axis2/C"
Re: [jira] Created: (AXIS2C-1157) When -Werror is in effect build break in util/src
Posted by Steven Nairn <st...@googlemail.com>.
The function axutil_hash_entry_free() is a static function (in both
1.4.0 and trunk). Therefore it can only be used in hash.c and is not
(and cannot be) part of the API.
It's not used in hash.c so I think it should be removed.
Cheers,
Steve Nairn
2008/5/23 Dimuthu Gamage <di...@gmail.com>:
> Yea, I agreed with Milinida, There are API functions that is not used
> anywhere inside Axis2. But used in some time codegen generated code or
> some other places like even wsf/php. So I think it is valid to have
> API functions not used inside axis2.
>
> Thanks
> Dimuthu
>
> On Fri, May 23, 2008 at 10:58 AM, Milinda Pathirage
> <mi...@gmail.com> wrote:
>> For example take function like 'axutil_date_time_is_utc' and runa grep on
>> Axis2/C source. This function is never used in our code. But we have
>> implemented it and one who implement service or client might use it in
>> his/her code. This kind of functions are there to provide consistent API to
>> the users who use this library to write their own services/clients. So I
>> think it's better not to use -Wunused-function flag (Currently we are using
>> -Wall in Axis2/C build and we will have to use seperate warning flags if we
>> encounter this kind of problems in future with new version of compilers).
>>
>> Thanks
>> Milinda
>>
>> On Fri, May 23, 2008 at 10:39 AM, Chintana Wilamuna <ch...@gmail.com>
>> wrote:
>>>
>>> On Fri, May 23, 2008 at 10:22 AM, Chintana Wilamuna <ch...@gmail.com>
>>> wrote:
>>>
>>> > Um .. I don't agree. This was found because of the "new changes to
>>> > gcc". Which is really helpful because it caught a function which is
>>> > not used anywhere. If it's not used why it's defined in the first
>>> > place? Why not remove it altogether until it's used somewhere.
>>> > Otherwise it'll take us nowhere because a defined function is not used
>>> > anywhere ;-)
>>>
>>> Milinda told me that there could be a function defined in axutil/axis2
>>> etc... and that not being used anywhere throughout the code. Sorry I
>>> didn't know that. In that case yeah, should change the build system.
>>>
>>> Bye,
>>>
>>> -Chintana
>>>
>>> --
>>> http://engwar.com/
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
>>> For additional commands, e-mail: axis-c-dev-help@ws.apache.org
>>>
>>
>>
>>
>> --
>> http://mpathirage.com
>> http://wso2.org "Oxygen for Web Service Developers"
>> http://wsaxc.blogspot.com "Web Services With Axis2/C"
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-c-dev-help@ws.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
Re: [jira] Created: (AXIS2C-1157) When -Werror is in effect build break in util/src
Posted by Dimuthu Gamage <di...@gmail.com>.
Yea, I agreed with Milinida, There are API functions that is not used
anywhere inside Axis2. But used in some time codegen generated code or
some other places like even wsf/php. So I think it is valid to have
API functions not used inside axis2.
Thanks
Dimuthu
On Fri, May 23, 2008 at 10:58 AM, Milinda Pathirage
<mi...@gmail.com> wrote:
> For example take function like 'axutil_date_time_is_utc' and runa grep on
> Axis2/C source. This function is never used in our code. But we have
> implemented it and one who implement service or client might use it in
> his/her code. This kind of functions are there to provide consistent API to
> the users who use this library to write their own services/clients. So I
> think it's better not to use -Wunused-function flag (Currently we are using
> -Wall in Axis2/C build and we will have to use seperate warning flags if we
> encounter this kind of problems in future with new version of compilers).
>
> Thanks
> Milinda
>
> On Fri, May 23, 2008 at 10:39 AM, Chintana Wilamuna <ch...@gmail.com>
> wrote:
>>
>> On Fri, May 23, 2008 at 10:22 AM, Chintana Wilamuna <ch...@gmail.com>
>> wrote:
>>
>> > Um .. I don't agree. This was found because of the "new changes to
>> > gcc". Which is really helpful because it caught a function which is
>> > not used anywhere. If it's not used why it's defined in the first
>> > place? Why not remove it altogether until it's used somewhere.
>> > Otherwise it'll take us nowhere because a defined function is not used
>> > anywhere ;-)
>>
>> Milinda told me that there could be a function defined in axutil/axis2
>> etc... and that not being used anywhere throughout the code. Sorry I
>> didn't know that. In that case yeah, should change the build system.
>>
>> Bye,
>>
>> -Chintana
>>
>> --
>> http://engwar.com/
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
>> For additional commands, e-mail: axis-c-dev-help@ws.apache.org
>>
>
>
>
> --
> http://mpathirage.com
> http://wso2.org "Oxygen for Web Service Developers"
> http://wsaxc.blogspot.com "Web Services With Axis2/C"
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
Re: [jira] Created: (AXIS2C-1157) When -Werror is in effect build break in util/src
Posted by Milinda Pathirage <mi...@gmail.com>.
For example take function like 'axutil_date_time_is_utc' and runa grep on
Axis2/C source. This function is never used in our code. But we have
implemented it and one who implement service or client might use it in
his/her code. This kind of functions are there to provide consistent API to
the users who use this library to write their own services/clients. So I
think it's better not to use -Wunused-function flag (Currently we are using
-Wall in Axis2/C build and we will have to use seperate warning flags if we
encounter this kind of problems in future with new version of compilers).
Thanks
Milinda
On Fri, May 23, 2008 at 10:39 AM, Chintana Wilamuna <ch...@gmail.com>
wrote:
> On Fri, May 23, 2008 at 10:22 AM, Chintana Wilamuna <ch...@gmail.com>
> wrote:
>
> > Um .. I don't agree. This was found because of the "new changes to
> > gcc". Which is really helpful because it caught a function which is
> > not used anywhere. If it's not used why it's defined in the first
> > place? Why not remove it altogether until it's used somewhere.
> > Otherwise it'll take us nowhere because a defined function is not used
> > anywhere ;-)
>
> Milinda told me that there could be a function defined in axutil/axis2
> etc... and that not being used anywhere throughout the code. Sorry I
> didn't know that. In that case yeah, should change the build system.
>
> Bye,
>
> -Chintana
>
> --
> http://engwar.com/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-c-dev-help@ws.apache.org
>
>
--
http://mpathirage.com
http://wso2.org "Oxygen for Web Service Developers"
http://wsaxc.blogspot.com "Web Services With Axis2/C"
Re: [jira] Created: (AXIS2C-1157) When -Werror is in effect build break in util/src
Posted by Chintana Wilamuna <ch...@gmail.com>.
On Fri, May 23, 2008 at 10:22 AM, Chintana Wilamuna <ch...@gmail.com> wrote:
> Um .. I don't agree. This was found because of the "new changes to
> gcc". Which is really helpful because it caught a function which is
> not used anywhere. If it's not used why it's defined in the first
> place? Why not remove it altogether until it's used somewhere.
> Otherwise it'll take us nowhere because a defined function is not used
> anywhere ;-)
Milinda told me that there could be a function defined in axutil/axis2
etc... and that not being used anywhere throughout the code. Sorry I
didn't know that. In that case yeah, should change the build system.
Bye,
-Chintana
--
http://engwar.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
Re: [jira] Created: (AXIS2C-1157) When -Werror is in effect build break in util/src
Posted by Chintana Wilamuna <ch...@gmail.com>.
On Fri, May 23, 2008 at 9:37 AM, Milinda Pathirage
<mi...@gmail.com> wrote:
> So I think we have to use correct flags which will make code compile in both
> gcc older versions and new versions. I propose other than using -Wall with
> -Werror, we must use following flags as necessary.
Um .. I don't agree. This was found because of the "new changes to
gcc". Which is really helpful because it caught a function which is
not used anywhere. If it's not used why it's defined in the first
place? Why not remove it altogether until it's used somewhere.
Otherwise it'll take us nowhere because a defined function is not used
anywhere ;-)
Bye,
-Chintana
--
http://engwar.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
Re: [jira] Created: (AXIS2C-1157) When -Werror is in effect build break in util/src
Posted by Milinda Pathirage <mi...@gmail.com>.
Forgot to mentioned the link in previous mail.
Link for "GCC 4.3 Release Series Porting to the New Tools"
http://gcc.gnu.org/gcc-4.3/porting_to.html
Thanks
Milinda
On Fri, May 23, 2008 at 9:37 AM, Milinda Pathirage <
milinda.pathirage@gmail.com> wrote:
> Hi all,
> I think these build errors caused by new warnings introduced by GCC 4.3.
> Here is part of their GCC 4.3 porting document.
>
> New warnings
>
> Significant changes were made to -Wconversion. In addition, improvements
> to the GCC infrastructure allow improvements in the ability of several
> existing warnings to spot problematic code. As such, new warnings may exist
> for previously warning-free code that uses -Wuninitialized, -Wstrict-aliasing
> , -Wunused-function, -Wunused-variable. Note that -Wall subsumes many of
> these warning flags.
>
> Although these warnings will not result in compilation failure, often
> -Wall is used in conjunction with -Werror and as a result, new warnings
> are turned into new errors.
>
> As a workaround, remove -Werror until the new warnings are fixed, or for
> conversion warnings add -Wno-conversion.
>
>
> So I think we have to use correct flags which will make code compile in
> both gcc older versions and new versions. I propose other than using -Wall
> with -Werror, we must use following flags as necessary.
>
> -Wuninitialized, -Wstrict-aliasing , -Wunused-function, -Wunused-variable
>
>
> Thanks
>
> Milinda
>
>
>
>
>
> On Thu, May 22, 2008 at 3:33 PM, Chintana Wilamuna (JIRA) <ji...@apache.org>
> wrote:
>
>> When -Werror is in effect build break in util/src
>> -------------------------------------------------
>>
>> Key: AXIS2C-1157
>> URL: https://issues.apache.org/jira/browse/AXIS2C-1157
>> Project: Axis2-C
>> Issue Type: Bug
>> Components: util
>> Affects Versions: 1.4.0
>> Environment: Fedora Core 9. GCC 4.3.0
>> Reporter: Chintana Wilamuna
>>
>>
>> GCC complains with the following error,
>>
>> hash.c:573: error: 'axutil_hash_entry_free' defined but not used
>> make[5]: *** [hash.lo] Error 1
>>
>> Since WSF/C uses all the modules I issued the following command to see
>> where axutil_hash_entry_free is being used,
>>
>> find wsf_c -iname '*.c' | xargs grep 'axutil_hash_entry_free'
>>
>> And found out that it's not being used anywhere. If it's not being used I
>> suggest at least commenting out the function since it breaks the build.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
>> For additional commands, e-mail: axis-c-dev-help@ws.apache.org
>>
>>
>
>
> --
> http://mpathirage.com
> http://wso2.org "Oxygen for Web Service Developers"
> http://wsaxc.blogspot.com "Web Services With Axis2/C"
--
http://mpathirage.com
http://wso2.org "Oxygen for Web Service Developers"
http://wsaxc.blogspot.com "Web Services With Axis2/C"
Re: [jira] Created: (AXIS2C-1157) When -Werror is in effect build break in util/src
Posted by Milinda Pathirage <mi...@gmail.com>.
Hi all,
I think these build errors caused by new warnings introduced by GCC 4.3.
Here is part of their GCC 4.3 porting document.
New warnings
Significant changes were made to -Wconversion. In addition, improvements to
the GCC infrastructure allow improvements in the ability of several existing
warnings to spot problematic code. As such, new warnings may exist for
previously warning-free code that uses -Wuninitialized, -Wstrict-aliasing ,
-Wunused-function, -Wunused-variable. Note that -Wall subsumes many of these
warning flags.
Although these warnings will not result in compilation failure, often
-Wallis used in conjunction with
-Werror and as a result, new warnings are turned into new errors.
As a workaround, remove -Werror until the new warnings are fixed, or for
conversion warnings add -Wno-conversion.
So I think we have to use correct flags which will make code compile in both
gcc older versions and new versions. I propose other than using -Wall with
-Werror, we must use following flags as necessary.
-Wuninitialized, -Wstrict-aliasing , -Wunused-function, -Wunused-variable
Thanks
Milinda
On Thu, May 22, 2008 at 3:33 PM, Chintana Wilamuna (JIRA) <ji...@apache.org>
wrote:
> When -Werror is in effect build break in util/src
> -------------------------------------------------
>
> Key: AXIS2C-1157
> URL: https://issues.apache.org/jira/browse/AXIS2C-1157
> Project: Axis2-C
> Issue Type: Bug
> Components: util
> Affects Versions: 1.4.0
> Environment: Fedora Core 9. GCC 4.3.0
> Reporter: Chintana Wilamuna
>
>
> GCC complains with the following error,
>
> hash.c:573: error: 'axutil_hash_entry_free' defined but not used
> make[5]: *** [hash.lo] Error 1
>
> Since WSF/C uses all the modules I issued the following command to see
> where axutil_hash_entry_free is being used,
>
> find wsf_c -iname '*.c' | xargs grep 'axutil_hash_entry_free'
>
> And found out that it's not being used anywhere. If it's not being used I
> suggest at least commenting out the function since it breaks the build.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-c-dev-help@ws.apache.org
>
>
--
http://mpathirage.com
http://wso2.org "Oxygen for Web Service Developers"
http://wsaxc.blogspot.com "Web Services With Axis2/C"
[jira] Commented: (AXIS2C-1157) When -Werror is in effect build
break in util/src
Posted by "Chintana Wilamuna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2C-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600378#action_12600378 ]
Chintana Wilamuna commented on AXIS2C-1157:
-------------------------------------------
As Steven noticed the function is declared as a static function. I suggest removing the static keyword IFF there's a need to expose this function. Otherwise remove it all together.
> When -Werror is in effect build break in util/src
> -------------------------------------------------
>
> Key: AXIS2C-1157
> URL: https://issues.apache.org/jira/browse/AXIS2C-1157
> Project: Axis2-C
> Issue Type: Bug
> Components: util
> Affects Versions: 1.4.0
> Environment: Fedora Core 9. GCC 4.3.0
> Reporter: Chintana Wilamuna
>
> GCC complains with the following error,
> hash.c:573: error: 'axutil_hash_entry_free' defined but not used
> make[5]: *** [hash.lo] Error 1
> Since WSF/C uses all the modules I issued the following command to see where axutil_hash_entry_free is being used,
> find wsf_c -iname '*.c' | xargs grep 'axutil_hash_entry_free'
> And found out that it's not being used anywhere. If it's not being used I suggest at least commenting out the function since it breaks the build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
[jira] Resolved: (AXIS2C-1157) When -Werror is in effect build
break in util/src
Posted by "Chintana Wilamuna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2C-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chintana Wilamuna resolved AXIS2C-1157.
---------------------------------------
Resolution: Fixed
Fix Version/s: Current (Nightly)
Manjula removed the static keyword.
http://svn.apache.org/viewvc/webservices/axis2/trunk/c/util/src/hash.c?r1=640677&r2=662659&diff_format=h
> When -Werror is in effect build break in util/src
> -------------------------------------------------
>
> Key: AXIS2C-1157
> URL: https://issues.apache.org/jira/browse/AXIS2C-1157
> Project: Axis2-C
> Issue Type: Bug
> Components: util
> Affects Versions: 1.4.0
> Environment: Fedora Core 9. GCC 4.3.0
> Reporter: Chintana Wilamuna
> Fix For: Current (Nightly)
>
>
> GCC complains with the following error,
> hash.c:573: error: 'axutil_hash_entry_free' defined but not used
> make[5]: *** [hash.lo] Error 1
> Since WSF/C uses all the modules I issued the following command to see where axutil_hash_entry_free is being used,
> find wsf_c -iname '*.c' | xargs grep 'axutil_hash_entry_free'
> And found out that it's not being used anywhere. If it's not being used I suggest at least commenting out the function since it breaks the build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org
[jira] Commented: (AXIS2C-1157) When -Werror is in effect build
break in util/src
Posted by "Steve Nairn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2C-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601881#action_12601881 ]
Steve Nairn commented on AXIS2C-1157:
-------------------------------------
What is the point in removing the "static" qualifier? Surely it would make more sense to just remove the function.
The function is not used in hash.c and has never been used since it was renamed from axis2_hash_entry_free in r524225. The function has never been used outside hash.c since (up until now) it has been static so has not been visible outside that file.
By removing the "static" qualifier the function is now visible outside hash.c so could be called on some architectures. By default Linux exports all global symbols from shared libraries so (in theory) it the function could be called on Linux. However, it won't be exported from the DLL on Windows as it's not marked AXIS2_EXTERN, so the Linux and Windows interfaces will be different.
Also, it's hard to see why anyone would want to call the function outside hash.c. The second parameter is a pointer to a axutil_hash_entry_t struct that is private to hash.c. The definition is not visible outside hash.c, so a potential caller couldn't call it with parameters of the correct type even if they wanted to.
It's dead code. Why not just remove the function?
Cheers,
Steve
> When -Werror is in effect build break in util/src
> -------------------------------------------------
>
> Key: AXIS2C-1157
> URL: https://issues.apache.org/jira/browse/AXIS2C-1157
> Project: Axis2-C
> Issue Type: Bug
> Components: util
> Affects Versions: 1.4.0
> Environment: Fedora Core 9. GCC 4.3.0
> Reporter: Chintana Wilamuna
> Fix For: Current (Nightly)
>
>
> GCC complains with the following error,
> hash.c:573: error: 'axutil_hash_entry_free' defined but not used
> make[5]: *** [hash.lo] Error 1
> Since WSF/C uses all the modules I issued the following command to see where axutil_hash_entry_free is being used,
> find wsf_c -iname '*.c' | xargs grep 'axutil_hash_entry_free'
> And found out that it's not being used anywhere. If it's not being used I suggest at least commenting out the function since it breaks the build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org