You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by bh...@apache.org on 2013/02/13 18:18:21 UTC

git commit: refs/heads/4.1 - CLOUDSTACK-710: CitrixResourceBase, if dest dir is not found, mkdir -m 700 -p

Updated Branches:
  refs/heads/4.1 131e20cd3 -> 0f317567d


CLOUDSTACK-710: CitrixResourceBase, if dest dir is not found, mkdir -m 700 -p

This is a security failsafe, so even if destination does not exist we mkdir the path
with 0700 permission. If path exists mkdir -m 700 -p won't do anything.

Signed-off-by: Rohit Yadav <bh...@apache.org>
(cherry picked from commit 3a0c99b0a430b12a492f2b93dec8d110603b43b4)

Signed-off-by: Rohit Yadav <bh...@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/0f317567
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/tree/0f317567
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/diff/0f317567

Branch: refs/heads/4.1
Commit: 0f317567d2f3fe7767a6bb05cc6cac725a0eee37
Parents: 131e20c
Author: Rohit Yadav <bh...@apache.org>
Authored: Wed Feb 13 22:45:32 2013 +0530
Committer: Rohit Yadav <bh...@apache.org>
Committed: Wed Feb 13 22:48:03 2013 +0530

----------------------------------------------------------------------
 .../xen/resource/CitrixResourceBase.java           |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/blob/0f317567/plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
----------------------------------------------------------------------
diff --git a/plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java b/plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
index c7ff5c7..b3cb54f 100644
--- a/plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
+++ b/plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
@@ -4763,7 +4763,7 @@ public abstract class CitrixResourceBase implements ServerResource, HypervisorRe
                             s_logger.debug("Copying " + f + " to " + d + " on " + hr.address + " with permission " + p);
                         }
                         try {
-                            session.execCommand("mkdir -p " + d);
+                            session.execCommand("mkdir -m 700 -p " + d);
                         } catch (IOException e) {
                             s_logger.debug("Unable to create destination path: " + d + " on " + hr.address + " but trying anyway");