You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "JingsongLi (via GitHub)" <gi...@apache.org> on 2026/06/11 03:35:23 UTC

[PR] Reject non-zero v1 reserved bytes [paimon-vector-index]

JingsongLi opened a new pull request, #36:
URL: https://github.com/apache/paimon-vector-index/pull/36

   ## Summary
   
   This PR tightens the v1 storage-format contract after #35 by requiring all reserved header bytes to be zero when reading. It also documents that index-file integrity is guaranteed by the outer Paimon file/manifest layer rather than by an embedded checksum/footer.
   
   ## Changes
   
   - Add a shared `validate_reserved_zero` helper.
   - Reject non-zero reserved bytes in IVFPQ, IVF-FLAT, IVF-HNSW-FLAT, and IVF-HNSW-SQ v1 headers.
   - Add targeted reader tests for non-zero reserved bytes across all four v1 formats.
   - Update `STORAGE_FORMAT.md` to state that reserved bytes are part of the v1 compatibility contract and must remain zero.
   - Document that checksum/length validation is handled by the outer Paimon layer.
   
   ## Testing
   
   - [x] `cargo test -p paimon-vindex-core --test storage_format_fixtures`
   - [x] `cargo test -p paimon-vindex-core --lib reserved`
   - [x] `cargo test -p paimon-vindex-core`
   - [x] `git diff --check`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Reject non-zero v1 reserved bytes [paimon-vector-index]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #36:
URL: https://github.com/apache/paimon-vector-index/pull/36


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org