You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Zoltan Haindrich <ki...@rxd.hu> on 2017/12/05 10:28:31 UTC
Review Request 64334: HIVE-15939 boolean cast expressions

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64334/
-----------------------------------------------------------

Review request for hive, Ashutosh Chauhan and Teddy Choi.


Bugs: HIVE-15939
    https://issues.apache.org/jira/browse/HIVE-15939


Repository: hive-git


Description
-------

* changes to make udf/vectorized cast expressions align with the serde counterparts


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 5c7d7eec8a54bff0193d769a559d2f3cbf49eef1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastStringToBoolean.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncStringToLong.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorExpression.java b5399d6ccf65ab11180e17320758f9a02085eded 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToBoolean.java d291e3659887f045b8274acb9502cd7ca44f6a75 
  ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorMathFunctions.java fb791160c6b1c376335124b824941423322e1b0c 
  ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTypeCasts.java fb8035b6875cd39c6dc011a70b15d53c246d91f7 
  ql/src/test/queries/clientpositive/udf_to_boolean.q 8bea7abcbc4d3b9c30d7deb6245cc9f55072875b 
  ql/src/test/queries/clientpositive/vector_udf_string_to_boolean.q PRE-CREATION 
  ql/src/test/results/clientpositive/udf_to_boolean.q.out ebce364bf7c4f1277cb7843221502d024a79f0b0 
  ql/src/test/results/clientpositive/vector_empty_where.q.out 609a36cb1a88ff9ff4ef9e1cfbee01c817fc12fb 
  ql/src/test/results/clientpositive/vector_udf_string_to_boolean.q.out PRE-CREATION 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java 6a4733f989f0033c9f84248ff385698ca6d0eec8 
  serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/primitive/TestPrimitiveObjectInspectorUtils.java 9d86a5494a366568f151493794ab7404e3b205f6 


Diff: https://reviews.apache.org/r/64334/diff/1/


Testing
-------


Thanks,

Zoltan Haindrich