[jira] [Commented] (MAPREDUCE-2249) Better to check the reflexive property of the object while overriding equals method of it

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021271#comment-13021271 ] 

Hadoop QA commented on MAPREDUCE-2249:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12472831/MAPREDUCE-2249-2.patch
  against trunk revision 1094093.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/172//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/172//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/172//console

This message is automatically generated.

> Better to check the reflexive property of the object while overriding equals method of it
> -----------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2249
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2249
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: jobtracker, tasktracker
>    Affects Versions: 0.22.0, 0.23.0
>         Environment: NA
>            Reporter: Bhallamudi Venkata Siva Kamesh
>            Assignee: Devaraj K
>         Attachments: MAPREDUCE-2249-1.patch, MAPREDUCE-2249-2.patch, MAPREDUCE-2249.patch
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> It is better to check the reflexive property of the object while overriding equals method of it.
>  
> It improves the performance when a heavy object is compared to itself.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira